Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make masthead links, Profile icon optional #101

Closed
sanjitbauli opened this issue Sep 21, 2019 · 3 comments
Closed

Make masthead links, Profile icon optional #101

sanjitbauli opened this issue Sep 21, 2019 · 3 comments
Assignees
@kennylam
Labels
dev Needs some dev work Feature request A new adopter requested feature package: react Work necessary for the Carbon for IBM.com react components package
Milestone
Sprint 20

Comments

@sanjitbauli
Copy link
Collaborator

sanjitbauli commented Sep 21, 2019 •
edited by RobertaJHahn
Loading

In URX we don't need any menu on the header, also the profile icon is not required, In Northstar header, there was an option masthead:'popup' this feature will help us to match the same behavior.

Make the masthead configurable, hide links, profile bypassing props to the component.

A duplicate of this issue has been created in the Digital Design board. Make the masthead configurable, hide links, profile bypassing props to the component
@ljcarot
Copy link
Member

ljcarot commented Sep 23, 2019

@jeffchew I believe we made masthead configurable. Can you confirm?

@sanjitbauli
Copy link
Collaborator Author

I don't see any option. Maybe i am missing the trick. FYI, i am using own css to hide the menu and profile section at this moment.

@ljcarot
Copy link
Member

ljcarot commented Sep 24, 2019

It will be coming out in next release. That's why you don't see it yet.

@jeffchew jeffchew added dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package bug Something isn't working labels Sep 24, 2019
@RobertaJHahn RobertaJHahn added Feature request A new adopter requested feature and removed bug Something isn't working labels Sep 26, 2019
@RobertaJHahn RobertaJHahn added this to the Sprint 20 milestone Sep 26, 2019
@RobertaJHahn RobertaJHahn changed the title Make mast head links, Profile icon optional Make masthead links, Profile icon optional Oct 7, 2019
@kennylam kennylam mentioned this issue Oct 10, 2019
Merged
@jeffchew jeffchew mentioned this issue Oct 15, 2019
Closed
@photodow photodow mentioned this issue Nov 4, 2019
Merged
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 16, 2022
@asudoh
chore(devenv): add more Vue stories (carbon-design-system#101)
1cc4684 
Refs carbon-design-system#88.
annawen1 pushed a commit that referenced this issue Sep 15, 2022
@asudoh
chore(devenv): add more Vue stories (#101)
5a80918 
Refs #88.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
dev Needs some dev work Feature request A new adopter requested feature package: react Work necessary for the Carbon for IBM.com react components package
Projects
None yet
Milestone
Sprint 20
Development

No branches or pull requests
5 participants
@sanjitbauli @kennylam @jeffchew @ljcarot @RobertaJHahn