-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(masthead): makes search and profile optional #184
feat(masthead): makes search and profile optional #184
Conversation
Deploy preview for ibmdotcom-react ready! Built with commit 75d5b68 |
Deploy preview for ibmdotcom-patterns-react-experimental ready! Built with commit fcb706b https://deploy-preview-184--ibmdotcom-patterns-react-experimental.netlify.com |
Deploy preview for ibmdotcom-react-experimental ready! Built with commit cd69f65 https://deploy-preview-184--ibmdotcom-react-experimental.netlify.com |
Deploy preview for ibmdotcom-patterns-react ready! Built with commit cd69f65 https://deploy-preview-184--ibmdotcom-patterns-react.netlify.com |
Deploy preview for ibmdotcom-patterns-react-experimental ready! Built with commit cd69f65 https://deploy-preview-184--ibmdotcom-patterns-react-experimental.netlify.com |
Deploy preview for ibmdotcom-react ready! Built with commit cd69f65 |
Deploy preview for ibmdotcom-utilities ready! Built with commit cd69f65 |
Deploy preview for ibmdotcom-services ready! Built with commit cd69f65 |
@oliviaflory This PR addresses #158 also. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
This change introduces `selectorItemEnabled` configuration in content switcher and tabs, to get simpler logic for navigation considering disabled items.
This change introduces `selectorItemEnabled` configuration in content switcher and tabs, to get simpler logic for navigation considering disabled items.
Related Ticket(s)
#101
Description
This change allows the Profile and Search components in the masthead to be optional. All masthead components (except the IBM logo) are now optional.
Changelog
New
Changed
Masthead
andDotcomShell
now share the same knobs forMasthead
component