Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(masthead): makes search and profile optional #184

Merged
merged 11 commits into from
Oct 15, 2019
Merged

feat(masthead): makes search and profile optional #184

merged 11 commits into from
Oct 15, 2019

Conversation

kennylam
Copy link
Member

Related Ticket(s)

#101

Description

This change allows the Profile and Search components in the masthead to be optional. All masthead components (except the IBM logo) are now optional.

Changelog

New

  • Search and profile are now optional

Changed

  • Masthead and DotcomShell now share the same knobs for Masthead component

@netlify
Copy link

netlify bot commented Oct 10, 2019

Deploy preview for ibmdotcom-react ready!

Built with commit 75d5b68

https://deploy-preview-184--ibmdotcom-react.netlify.com

@netlify
Copy link

netlify bot commented Oct 10, 2019

Deploy preview for ibmdotcom-patterns-react-experimental ready!

Built with commit fcb706b

https://deploy-preview-184--ibmdotcom-patterns-react-experimental.netlify.com

@netlify
Copy link

netlify bot commented Oct 10, 2019 •
edited
Loading

Deploy preview for ibmdotcom-react-experimental ready!

Built with commit cd69f65

https://deploy-preview-184--ibmdotcom-react-experimental.netlify.com

@netlify
Copy link

netlify bot commented Oct 10, 2019 •
edited
Loading

Deploy preview for ibmdotcom-patterns-react ready!

Built with commit cd69f65

https://deploy-preview-184--ibmdotcom-patterns-react.netlify.com

@netlify
Copy link

netlify bot commented Oct 10, 2019 •
edited
Loading

Deploy preview for ibmdotcom-patterns-react-experimental ready!

Built with commit cd69f65

https://deploy-preview-184--ibmdotcom-patterns-react-experimental.netlify.com

@netlify
Copy link

netlify bot commented Oct 10, 2019 •
edited
Loading

Deploy preview for ibmdotcom-react ready!

Built with commit cd69f65

https://deploy-preview-184--ibmdotcom-react.netlify.com

@netlify
Copy link

netlify bot commented Oct 10, 2019 •
edited
Loading

Deploy preview for ibmdotcom-utilities ready!

Built with commit cd69f65

https://deploy-preview-184--ibmdotcom-utilities.netlify.com

@netlify
Copy link

netlify bot commented Oct 10, 2019 •
edited
Loading

Deploy preview for ibmdotcom-services ready!

Built with commit cd69f65

https://deploy-preview-184--ibmdotcom-services.netlify.com

@kennylam
Copy link
Member Author

@oliviaflory This PR addresses #158 also.

oliviaflory
oliviaflory approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@oliviaflory oliviaflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@kennylam kennylam merged commit 50b832c into carbon-design-system:master Oct 15, 2019
@kennylam kennylam deleted the feat/masthead-profile-search branch October 16, 2019 02:01
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 16, 2022
@asudoh
chore(content-switcher): optimize navigation (carbon-design-system#184)
9dec39a 
This change introduces `selectorItemEnabled` configuration in content
switcher and tabs, to get simpler logic for navigation considering
disabled items.
annawen1 pushed a commit that referenced this pull request Sep 15, 2022
@asudoh
chore(content-switcher): optimize navigation (#184)
d0bc765 
This change introduces `selectorItemEnabled` configuration in content
switcher and tabs, to get simpler logic for navigation considering
disabled items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@oliviaflory oliviaflory oliviaflory approved these changes

@annawen1 annawen1 Awaiting requested review from annawen1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kennylam @jeffchew @oliviaflory