Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pattern: develop content block - simple (w/o media) #466

Closed
1 task
jeffchew opened this issue Oct 13, 2019 · 5 comments
Closed
1 task

Pattern: develop content block - simple (w/o media) #466

jeffchew opened this issue Oct 13, 2019 · 5 comments
Assignees
@sannminwin
Labels
dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package sprint demo Sprint Must Have
Milestone
Sprint 21

Comments

@jeffchew
Copy link
Member

jeffchew commented Oct 13, 2019 •
edited by RobertaJHahn

hahnrob created the following on Sep 19:

User Story

As a [user role below]:
developer using the ibm.com Library

I need to:
have a content block - simple pattern that can be used

so that I can:
leverage it within my application

Additional information

Acceptance criteria

  • tested React component within the Patterns Storybook

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1735
@jeffchew jeffchew added this to the Sprint 20 milestone Oct 13, 2019
@jeffchew jeffchew mentioned this issue Oct 15, 2019
Closed
@sannminwin
Copy link
Contributor

created pull request.
#561

@RobertaJHahn
Copy link

Presented in the Oct 28 Sprint Review meeting. Closing.

@jeffchew jeffchew mentioned this issue Oct 29, 2019
Closed
@sannminwin sannminwin mentioned this issue Oct 29, 2019
Merged
@jeffchew
Copy link
Member Author

Note, this story did not make code freeze for v1.1.0. It will be available as alpha via canary releases, and will also be part of v1.2.0.

cc: @RobertaJHahn @ljcarot @wonilsuhibm @sannminwin

@ljcarot ljcarot reopened this Oct 31, 2019
@ljcarot ljcarot modified the milestones: Sprint 20, Sprint 21 Oct 31, 2019
@ljcarot
Copy link
Member

ljcarot commented Oct 31, 2019

Reopening since this work is continuing into Sprint 21

@sannminwin
Copy link
Contributor

I have updated the simple long form and available for review now.
Thanks

preview
pull request

jeffchew added a commit that referenced this issue Nov 5, 2019
@jeffchew
Merge pull request #561 from sannminwin/466
980ed94 
feat(pattern): created simple long form pattern, resolves #466
@RobertaJHahn RobertaJHahn changed the title Pattern: develop simple long form section (w/o images) Pattern: develop simple long form section (w/o media) Nov 11, 2019
@RobertaJHahn RobertaJHahn changed the title Pattern: develop simple long form section (w/o media) Pattern: develop content block - simple (w/o media) Jan 16, 2020
@RobertaJHahn RobertaJHahn added package: react Work necessary for the Carbon for IBM.com react components package and removed package: patterns labels Sep 30, 2020
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 16, 2022
@asudoh @kodiakhq
chore(react-wrapper): support mixins (carbon-design-system#466)
82ae759 
This change attempts to support custom element classes using mixins for
react wrapper generation code.

Also attempts to better support inheritances.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
annawen1 pushed a commit that referenced this issue Sep 15, 2022
@asudoh @kodiakhq
chore(react-wrapper): support mixins (#466)
ab8aadc 
This change attempts to support custom element classes using mixins for
react wrapper generation code.

Also attempts to better support inheritances.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sannminwin sannminwin

Labels
dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package sprint demo Sprint Must Have
Projects
None yet
Milestone
Sprint 21
Development

No branches or pull requests
10 participants
@kennylam @jeffchew @photodow @sannminwin @ljcarot @oliviaflory @RobertaJHahn @larahanlon2 @annawen1 @andysherman2121