Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-table): center align checkboxes #11743

Merged
merged 4 commits into from
May 2, 2024
Merged

fix(data-table): center align checkboxes #11743

merged 4 commits into from
May 2, 2024

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Apr 24, 2024

Related Ticket(s)

Closes #11742

Description

This PR center aligns data table checkboxes within their flexbox divs in order to avoid reliance on inconsistent vertical-align implementations across various browsers

Changelog

New

  • data table checkbox flexbox alignment rule

@emyarod emyarod requested a review from a team as a code owner April 24, 2024 19:28
@emyarod emyarod requested review from ariellalgilmore and annawen1 and removed request for a team April 24, 2024 19:28
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 24, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11743/index.html

Built with commit: 87b2e70827412241208b97110ee809268e4098ec

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 24, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11743/index.html

Built with commit: 87b2e70827412241208b97110ee809268e4098ec

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 24, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11743/index.html

Built with commit: 87b2e70827412241208b97110ee809268e4098ec

kennylam
kennylam approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @emyarod!

@kennylam kennylam closed this Apr 30, 2024
@kennylam kennylam reopened this Apr 30, 2024
@kennylam kennylam added package: carbon web components Ready to merge Label for the pull requests that are ready to merge labels May 2, 2024
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11743/index.html

Built with commit: 87b2e70827412241208b97110ee809268e4098ec

@kodiakhq kodiakhq bot merged commit 3c045f5 into carbon-design-system:main May 2, 2024
12 of 19 checks passed
@emyarod emyarod deleted the 11742-fix/data-table-selection-checkbox-alignment branch May 13, 2024 18:34
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.9.0.

kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@emyarod
fix(data-table): center align checkboxes (carbon-design-system#11743)
942a3d3 
### Related Ticket(s)

Closes carbon-design-system#11742

### Description

This PR center aligns data table checkboxes within their flexbox divs in order to avoid reliance on inconsistent `vertical-align` implementations across various browsers

### Changelog

**New**

- data table checkbox flexbox alignment rule

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alignment of checkboxes in data table with selection misaligned in Firefox
3 participants
@emyarod @ibmdotcom-bot @kennylam