Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (structured-list): Enable custom max-cols values #11804

Merged
merged 2 commits into from
May 24, 2024
Merged

fix (structured-list): Enable custom max-cols values #11804

merged 2 commits into from
May 24, 2024

Conversation

andy-blum
Copy link
Member

Related Ticket(s)

https://jsw.ibm.com/browse/ADCMS-5014

Description

This PR moves the --max-cols definitions to the top-level structured-list and pricing-table components. Previously, each row element set this value, leading to lg breakpoints always calculating against an assumed value of 16-cols

This change was needed to make the table work more intuitively in situations where it isn't displayed in a full 16-column container, for example within the table-of-contents component.

Before this PR, a pricing table 12-cols wide, with three table-columns each set to be 4-cols wide would set each table-column to be 25% width (4/16).
Screenshot 2024-05-17 at 11 14 54 AM

With this PR, the pricing table can set --max-cols: 12 and have those same table-columns set to 33.333% width (4/12)
Screenshot 2024-05-17 at 11 15 39 AM

Changelog

Changed

  • Enable custom --max-col values in structured-list and pricing-table components

@andy-blum andy-blum added the owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants label May 20, 2024
@andy-blum andy-blum requested a review from a team as a code owner May 20, 2024 19:11
@andy-blum andy-blum requested review from kennylam and emyarod and removed request for a team May 20, 2024 19:11
@andy-blum andy-blum changed the base branch from main to v1 May 20, 2024 19:11
@andy-blum andy-blum requested a review from jkaeser May 20, 2024 19:14
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 20, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11804/index.html

Built with commit: 9aa3f261e7b6eca61fbd6a33a788faa93a482e18

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 20, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11804/index.html

Built with commit: 9aa3f261e7b6eca61fbd6a33a788faa93a482e18

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 20, 2024 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11804/index.html

Built with commit: 9aa3f261e7b6eca61fbd6a33a788faa93a482e18

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 20, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11804/index.html

Built with commit: 9aa3f261e7b6eca61fbd6a33a788faa93a482e18

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 20, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11804/index.html

Built with commit: 9aa3f261e7b6eca61fbd6a33a788faa93a482e18

jkaeser
jkaeser approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@jkaeser jkaeser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andy-blum andy-blum closed this May 21, 2024
@andy-blum andy-blum reopened this May 21, 2024
emyarod
emyarod approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

m4olivei
m4olivei approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. Thanks for a great PR description. Logic is solid.

@jkaeser jkaeser added the Ready to merge Label for the pull requests that are ready to merge label May 24, 2024
@kodiakhq kodiakhq bot merged commit 095e87c into carbon-design-system:v1 May 24, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4olivei m4olivei m4olivei approved these changes

@emyarod emyarod emyarod approved these changes

@jkaeser jkaeser jkaeser approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andy-blum @ibmdotcom-bot @m4olivei @emyarod @jkaeser