feat(content-item-row): add shadow parts #11813
Conversation
Valentin-Sorin-Nicolae
requested review from
kennylam and
emyarod
and removed request for
a team
|
Deploy preview created for package Built with commit: 5734a402691c851d23f5d1394d4f82f1c0680030 |
|
Deploy preview created for package Built with commit: 5734a402691c851d23f5d1394d4f82f1c0680030 |
|
Deploy preview created for package Built with commit: 5734a402691c851d23f5d1394d4f82f1c0680030 |
|
Deploy preview created for package Built with commit: 5734a402691c851d23f5d1394d4f82f1c0680030 |
andy-blum
requested review from
m4olivei,
bruno-amorim,
jkaeser and
marcelojcs
and removed request for
kennylam and
emyarod
There was a problem hiding this comment.
Interested to get @jkaeser / @andy-blum 's take on my suggested changes here.
packages/web-components/src/components/content-item-row/content-item-row-media-featured.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/content-item-row/content-item-row-media-featured.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/content-item-row/content-item-row-media-featured.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/content-item-row/content-item-row-media-featured.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/content-item-row/content-item-row-media.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/content-item-row/content-item-row-media.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/content-item-row/content-item-row-media.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/content-item-row/content-item-row-media.ts
Outdated
Show resolved
Hide resolved
…t-item-row-media-featured.ts Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
…t-item-row-media-featured.ts Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
…t-item-row-media-featured.ts Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
…t-item-row-media-featured.ts Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
…t-item-row-media.ts Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
…t-item-row-media.ts Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
…t-item-row-media.ts Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
…t-item-row-media.ts Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
…gn-system/carbon-for-ibm-dotcom into content-item-row-shadow-part
packages/web-components/src/components/content-item-row/content-item-row-media-featured.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/content-item-row/content-item-row.ts
Outdated
Show resolved
Hide resolved
|
Just need to fix the ci-check errors. I think you'll need to:
|
There was a problem hiding this comment.
Just noticed that Prettier isn't happy with the changes here. See the job output: https://github.com/carbon-design-system/carbon-for-ibm-dotcom/actions/runs/9271220474/job/25506076670?pr=11813
I'll quick push a commit to fix. However, @Valentin-Sorin-Nicolae , be sure to configure your editor to use Prettier. I believe you use VSCode, @jkaeser and @andy-blum both do as well, so they could help you with setting it up it you need.
|
Haha! @jkaeser and I are both here at the same time :). I just fixed prettier / formatting. Snapshots are all that's left then. |
m4olivei
merged commit 1ea133b
into
carbon-design-system:feat/v2-shadow-parts
ADCMS-5063
Description
All non-slot elements in the shadow DOM should be given a unique "part" name allowing CSS to target and override component default styles. This is for the "content-item-row" component.
Changelog
New
Adding the shadow parts for the "content-item-row" component