Skip to content

Commit

Permalink
Merge pull request #1770 from carbon-design-system/fix/library-ref-no…
Browse files Browse the repository at this point in the history
…t-found

fix(web-app): gracefully handle library ref not found
  • Loading branch information
jdharvey-ibm committed Oct 4, 2023
2 parents b7ccd17 + 2d244b4 commit 983152b
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 1 deletion.
2 changes: 2 additions & 0 deletions services/web-app/data/libraries.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ const prodLibraries = {
host: 'github.com',
org: 'carbon-design-system',
repo: 'carbon-components-vue',
ref: 'vue2',
path: '/packages/core/src',
packageJsonPath: '/../package.json',
group: carbonComponentsGroup
Expand Down Expand Up @@ -256,6 +257,7 @@ const devLibraries = {
host: 'github.com',
org: 'carbon-design-system',
repo: 'carbon-components-vue',
ref: 'vue2',
path: '/packages/core/src',
packageJsonPath: '/../package.json',
group: carbonComponentsGroup
Expand Down
1 change: 1 addition & 0 deletions services/web-app/lib/github.js
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,7 @@ export const getAssetRelatedFrameworks = withTrace(
}
const relatedLibData = await getLibraryData(libParams)
if (
relatedLibData &&
relatedLibData?.content.id !== library.content.id &&
relatedLibData.assets?.length &&
!relatedLibData.assets[0].content?.noIndex &&
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"expireTime":1727969557151,"key":"github.com GET /repos/carbon-design-system/carbon-components-vue/contents/packages/core/src/thumbnails/toast-notification.svg ref=vue2","val":{"name":"toast-notification.svg","path":"packages/core/src/thumbnails/toast-notification.svg","sha":"4c481f9a4d05b2e5acb6bb397d5229966ecb80be","size":2204,"url":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/contents/packages/core/src/thumbnails/toast-notification.svg?ref=vue2","html_url":"https://github.com/carbon-design-system/carbon-components-vue/blob/vue2/packages/core/src/thumbnails/toast-notification.svg","git_url":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/git/blobs/4c481f9a4d05b2e5acb6bb397d5229966ecb80be","download_url":"https://raw.githubusercontent.com/carbon-design-system/carbon-components-vue/vue2/packages/core/src/thumbnails/toast-notification.svg","type":"file","content":"PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiB3aWR0aD0iMzIwIiBoZWlnaHQ9IjE4MCI+PGRlZnM+PGNpcmNsZSBpZD0iYSIgY3g9IjYuMTI1IiBjeT0iNi4xMjUiIHI9IjYuMTI1Ii8+PHBhdGggaWQ9ImIiIGQ9Ik0zLjAwNy0uMzQyaC45ODR2Ny42NzhoLS45ODR6Ii8+PC9kZWZzPjxnIGZpbGw9Im5vbmUiIGZpbGwtcnVsZT0iZXZlbm9kZCI+PHBhdGggZmlsbD0iIzM5MzkzOSIgZD0iTTYwIDU2aDIwMHY2OEg2MHoiLz48cGF0aCBmaWxsPSIjREExRTI4IiBkPSJNNjAgNTZoM3Y2OGgtM3oiLz48dXNlIHhsaW5rOmhyZWY9IiNhIiBmaWxsPSIjREExRTI4IiB0cmFuc2Zvcm09Im1hdHJpeCgtMSAwIDAgMSA4Ni4xMjUgNjguODc1KSIvPjx1c2UgeGxpbms6aHJlZj0iI2IiIGZpbGw9IiMwMDAiIHRyYW5zZm9ybT0ic2NhbGUoLTEgMSkgcm90YXRlKC00NSA0OC4wNTcgMTQwLjA0KSIvPjxwYXRoIGQ9Ik04NyA2OEg3M3YxNGgxNHoiLz48cGF0aCBmaWxsPSIjRjRGNEY0IiBkPSJNOTUgNzJoNzEuMTE5djVIOTV6Ii8+PHBhdGggZmlsbD0iI0UwRTBFMCIgZD0iTTk1IDEwNWg5My44NDR2NUg5NXpNOTUgODJoMTIzdjVIOTV6Ii8+PC9nPjwvc3ZnPg==","encoding":"base64","_links":{"self":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/contents/packages/core/src/thumbnails/toast-notification.svg?ref=vue2","git":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/git/blobs/4c481f9a4d05b2e5acb6bb397d5229966ecb80be","html":"https://github.com/carbon-design-system/carbon-components-vue/blob/vue2/packages/core/src/thumbnails/toast-notification.svg"}}}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"expireTime":1727969557272,"key":"github.com GET /repos/carbon-design-system/carbon-components-vue/contents/packages/core/package.json ref=vue2","val":{"name":"package.json","path":"packages/core/package.json","sha":"124b69e3f0839db6f1b6fb9ce6aa42ad85af911b","size":2188,"url":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/contents/packages/core/package.json?ref=vue2","html_url":"https://github.com/carbon-design-system/carbon-components-vue/blob/vue2/packages/core/package.json","git_url":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/git/blobs/124b69e3f0839db6f1b6fb9ce6aa42ad85af911b","download_url":"https://raw.githubusercontent.com/carbon-design-system/carbon-components-vue/vue2/packages/core/package.json","type":"file","content":"ewogICJuYW1lIjogIkBjYXJib24vdnVlIiwKICAiZGVzY3JpcHRpb24iOiAi\nQSBjb2xsZWN0aW9uIG9mIGNvbXBvbmVudHMgZm9yIHRoZSBDYXJib24gRGVz\naWduIFN5c3RlbSBidWlsdCB1c2luZyBWdWUuanMiLAogICJ2ZXJzaW9uIjog\nIjIuNDUuMSIsCiAgImxpY2Vuc2UiOiAiQXBhY2hlLTIuMCIsCiAgInJlcG9z\naXRvcnkiOiB7CiAgICAidHlwZSI6ICJnaXQiLAogICAgInVybCI6ICJnaXQr\naHR0cHM6Ly9naXRodWIuY29tL2NhcmJvbi1kZXNpZ24tc3lzdGVtL2NhcmJv\nbi1jb21wb25lbnRzLXZ1ZS5naXQiCiAgfSwKICAiYnVncyI6IHsKICAgICJ1\ncmwiOiAiaHR0cHM6Ly9naXRodWIuY29tL2NhcmJvbi1kZXNpZ24tc3lzdGVt\nL2NhcmJvbi1jb21wb25lbnRzLXZ1ZS9pc3N1ZXMvbmV3IgogIH0sCiAgImhv\nbWVwYWdlIjogImh0dHA6Ly92dWUuY2FyYm9uZGVzaWduc3lzdGVtLmNvbS8i\nLAogICJtYWluIjogImRpc3QvY2FyYm9uLXZ1ZS51bWQubWluLmpzIiwKICAi\na2V5d29yZHMiOiBbCiAgICAiY2FyYm9uIiwKICAgICJ2dWUiLAogICAgImNv\nbXBvbmVudHMiCiAgXSwKICAiZGlyZWN0b3JpZXMiOiB7CiAgICAic3JjIjog\nInNyYyIsCiAgICAidGVzdCI6ICJfX3Rlc3RzX18iCiAgfSwKICAicHVibGlz\naENvbmZpZyI6IHsKICAgICJhY2Nlc3MiOiAicHVibGljIgogIH0sCiAgImNv\nbnRyaWJ1dG9ycyI6IFsKICAgIHsKICAgICAgIm5hbWUiOiAiTGVlIENoYXNl\nIiwKICAgICAgImVtYWlsIjogImxlZS5jaGFzZUB1ay5pYm0uY29tIgogICAg\nfSwKICAgIHsKICAgICAgIm5hbWUiOiAiU2ltb24gTW9vcmUiLAogICAgICAi\nZW1haWwiOiAibW9vcmVzQHVrLmlibS5jb20iCiAgICB9LAogICAgewogICAg\nICAibmFtZSI6ICJNYXJpaWEgWnJpYW5pbmEiLAogICAgICAiZW1haWwiOiAi\nbXpyaWFuaW5AZGUuaWJtLmNvbSIKICAgIH0sCiAgICB7CiAgICAgICJuYW1l\nIjogIkRhdmUgQ2xhcmsiLAogICAgICAiZW1haWwiOiAiZGF2ZS5jbGFya0B1\nay5pYm0uY29tIgogICAgfSwKICAgIHsKICAgICAgIm5hbWUiOiAiT2xla3Nh\nbmRyIFNhYm92IiwKICAgICAgImVtYWlsIjogInNhYm92QGRlLmlibS5jb20i\nCiAgICB9LAogICAgewogICAgICAibmFtZSI6ICJDb25yYWQgU2NobWlkdCIs\nCiAgICAgICJlbWFpbCI6ICJjb25yYWQuc2NobWlkdEBkZS5pYm0uY29tIgog\nICAgfQogIF0sCiAgImZpbGVzIjogWwogICAgIi9kaXN0IiwKICAgICIvc3Jj\nIgogIF0sCiAgInNjcmlwdHMiOiB7CiAgICAiYnVpbGQiOiAidnVlLWNsaS1z\nZXJ2aWNlIGJ1aWxkIC0tdGFyZ2V0IGxpYiAtLW5hbWUgY2FyYm9uLXZ1ZSAu\nL3NyYy9pbmRleC5qcyAtLW5vLWNsZWFuIiwKICAgICJjbGVhbiI6ICJyaW1y\nYWYgZGlzdCBub2RlX21vZHVsZXMvLmNhY2hlIiwKICAgICJwb3N0aW5zdGFs\nbCI6ICJjYXJib24tdGVsZW1ldHJ5IGNvbGxlY3QgLS1pbnN0YWxsIiwKICAg\nICJ1cGdyYWRlOmRlcGVuZGVuY2llcyI6ICJydW4tcyAtcyAndXBncmFkZTpk\nZXBlbmRlbmNpZXM6KiciLAogICAgInVwZ3JhZGU6ZGVwZW5kZW5jaWVzOmNh\ncmJvbiI6ICJucG0tY2hlY2stdXBkYXRlcyAtdSAtLWRlcCBkZXYscGVlcixw\ncm9kICAtLWZpbHRlciAnL2NhcmJvbi8nIC0tdGFyZ2V0IG1pbm9yIiwKICAg\nICJ1cGdyYWRlOmRlcGVuZGVuY2llczpvdGhlciI6ICJucG0tY2hlY2stdXBk\nYXRlcyAtdSAtLWRlcCBkZXYscGVlcixwcm9kIC0tY29sb3IgLS1yZWplY3Qg\nJy8oY2FyYm9ufF52dWUkfF5AdnVlKS8nIiwKICAgICJ1cGdyYWRlOmRlcGVu\nZGVuY2llczp5YXJuIjogInlhcm4gc2V0IHZlcnNpb24gbGF0ZXN0IgogIH0s\nCiAgImVuZ2luZXMiOiB7CiAgICAibm9kZSI6ICI+PTEwLngiCiAgfSwKICAi\nc2lkZUVmZmVjdHMiOiB0cnVlLAogICJkZXBlbmRlbmNpZXMiOiB7CiAgICAi\nQGNhcmJvbi9pY29ucy12dWUiOiAiMTAuNjMuMCIsCiAgICAiQGNhcmJvbi90\nZWxlbWV0cnkiOiAiXjAuMS4wIiwKICAgICJjYXJib24tY29tcG9uZW50cyI6\nICIxMC41OC41IiwKICAgICJmbGF0cGlja3IiOiAiNC42LjEzIiwKICAgICJ2\ndWUiOiAiXjIuNy4xMCIKICB9LAogICJkZXZEZXBlbmRlbmNpZXMiOiB7CiAg\nICAiQHZ1ZS9jbGktc2VydmljZSI6ICJ+NC41LjE5IiwKICAgICJlc2xpbnQt\ncGx1Z2luLXByZXR0aWVyIjogIl40LjIuMSIsCiAgICAidnVlLXRlbXBsYXRl\nLWNvbXBpbGVyIjogIl4yLjcuMTQiCiAgfQp9Cg==\n","encoding":"base64","_links":{"self":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/contents/packages/core/package.json?ref=vue2","git":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/git/blobs/124b69e3f0839db6f1b6fb9ce6aa42ad85af911b","html":"https://github.com/carbon-design-system/carbon-components-vue/blob/vue2/packages/core/package.json"}}}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"expireTime":1727969557097,"key":"github.com GET /repos/carbon-design-system/carbon-components-vue/contents/packages/core/src/thumbnails/inline-notification.svg ref=vue2","val":{"name":"inline-notification.svg","path":"packages/core/src/thumbnails/inline-notification.svg","sha":"12759c86c6fc95614cb1bda560da786d960aadaa","size":1341,"url":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/contents/packages/core/src/thumbnails/inline-notification.svg?ref=vue2","html_url":"https://github.com/carbon-design-system/carbon-components-vue/blob/vue2/packages/core/src/thumbnails/inline-notification.svg","git_url":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/git/blobs/12759c86c6fc95614cb1bda560da786d960aadaa","download_url":"https://raw.githubusercontent.com/carbon-design-system/carbon-components-vue/vue2/packages/core/src/thumbnails/inline-notification.svg","type":"file","content":"PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiB3aWR0aD0iMzIwIiBoZWlnaHQ9IjE4MCI+PGRlZnM+PGNpcmNsZSBpZD0iYSIgY3g9IjUiIGN5PSI1IiByPSI0LjM3NSIvPjxwYXRoIGlkPSJiIiBkPSJNNC4zNzUgNi43MTkgMi44MTIgNS4xNTZsLjQ5Ny0uNDY4IDEuMDY2IDEuMDQ2IDIuMzE2LTIuMjk2LjQ5Ny40OTN6Ii8+PC9kZWZzPjxnIGZpbGw9Im5vbmUiIGZpbGwtcnVsZT0iZXZlbm9kZCI+PHBhdGggZmlsbD0iIzM5MzkzOSIgZD0iTTYwIDc3aDIwMHYyNkg2MHoiLz48ZyB0cmFuc2Zvcm09InRyYW5zbGF0ZSg2OSA4NSkiPjx1c2UgeGxpbms6aHJlZj0iI2EiIGZpbGw9IiMyNEExNDgiLz48dXNlIHhsaW5rOmhyZWY9IiNiIiBmaWxsPSIjRkZGIi8+PC9nPjxwYXRoIGZpbGw9IiMyNEExNDgiIGQ9Ik02MCA3N2gydjI2aC0yeiIvPjxwYXRoIGZpbGw9IiNGNEY0RjQiIGQ9Ik04NSA4OGgxMDAuMDg4djRIODV6Ii8+PC9nPjwvc3ZnPg==","encoding":"base64","_links":{"self":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/contents/packages/core/src/thumbnails/inline-notification.svg?ref=vue2","git":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/git/blobs/12759c86c6fc95614cb1bda560da786d960aadaa","html":"https://github.com/carbon-design-system/carbon-components-vue/blob/vue2/packages/core/src/thumbnails/inline-notification.svg"}}}

This file was deleted.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"expireTime":1727969557092,"key":"github.com GET /repos/carbon-design-system/carbon-components-vue/contents/packages/core/src/thumbnails/skeleton-text.svg ref=vue2","val":{"name":"skeleton-text.svg","path":"packages/core/src/thumbnails/skeleton-text.svg","sha":"f0a5ff7f7eb4a24ace31335bcc5caefd14d7da37","size":989,"url":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/contents/packages/core/src/thumbnails/skeleton-text.svg?ref=vue2","html_url":"https://github.com/carbon-design-system/carbon-components-vue/blob/vue2/packages/core/src/thumbnails/skeleton-text.svg","git_url":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/git/blobs/f0a5ff7f7eb4a24ace31335bcc5caefd14d7da37","download_url":"https://raw.githubusercontent.com/carbon-design-system/carbon-components-vue/vue2/packages/core/src/thumbnails/skeleton-text.svg","type":"file","content":"PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIzMjAiIGhlaWdodD0iMTgwIj48ZGVmcz48bGluZWFyR3JhZGllbnQgaWQ9ImEiIHgxPSItMjEuOTc4JSIgeDI9IjExMy40NzElIiB5MT0iNTAlIiB5Mj0iNTAlIj48c3RvcCBvZmZzZXQ9IjAlIiBzdG9wLWNvbG9yPSIjQzZDNkM2IiBzdG9wLW9wYWNpdHk9IjAiLz48c3RvcCBvZmZzZXQ9IjEwMCUiIHN0b3AtY29sb3I9IiNDNkM2QzYiLz48L2xpbmVhckdyYWRpZW50PjwvZGVmcz48ZyBmaWxsPSJub25lIiBmaWxsLXJ1bGU9ImV2ZW5vZGQiPjxwYXRoIGZpbGw9IiNFMEUwRTAiIGQ9Ik01NiA4MmgyMDh2MTZINTZ6Ii8+PHBhdGggZmlsbD0iI0M2QzZDNiIgZD0iTTU2IDgyaDE1NnYxNkg1NnoiLz48cGF0aCBmaWxsPSJ1cmwoI2EpIiBkPSJNMjEyIDgyaDd2MTZoLTd6IiB0cmFuc2Zvcm09Im1hdHJpeCgtMSAwIDAgMSA0MzEgMCkiLz48L2c+PC9zdmc+","encoding":"base64","_links":{"self":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/contents/packages/core/src/thumbnails/skeleton-text.svg?ref=vue2","git":"https://api.github.com/repos/carbon-design-system/carbon-components-vue/git/blobs/f0a5ff7f7eb4a24ace31335bcc5caefd14d7da37","html":"https://github.com/carbon-design-system/carbon-components-vue/blob/vue2/packages/core/src/thumbnails/skeleton-text.svg"}}}

Large diffs are not rendered by default.

0 comments on commit 983152b

Please sign in to comment.