Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-app): gracefully handle library ref not found #1770

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

jdharvey-ibm
Copy link
Member

@jdharvey-ibm jdharvey-ibm commented Oct 4, 2023

When getting asset related frameworks, if the library data was undefined/null, it is now excluded from the result set.

Also update carbon-components-vue's ref to be vue2

Verified by manual testing in local dev environment.

Steps to test

  • Add a ref that doesn't exist to a random library from libraries.mjs
  • Run the dev server
  • Verify that the libraries page still loads, but the missing ref lib is excluded from the page.

When getting asset related frameworks, if the library data was undefined/null, it is now excluded
from the result set.

Also update carbon-components-vue's ref to be `vue2`
@carbon-bot
Copy link
Contributor

The commits in this PR will result in the following version changes:

🐛 PATCH release: @carbon-platform/web-app

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jdharvey-ibm jdharvey-ibm merged commit 983152b into main Oct 4, 2023
6 checks passed
@jdharvey-ibm jdharvey-ibm deleted the fix/library-ref-not-found branch October 4, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants