This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
fix(number-input): fix for React #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes `<bx-number-input>` code support the Babel plugin that generates its React wrapper, by putting the getters of declared properties before their setters. This change also ensures that failures in such Babel plugin causes CI error.
|
Deploy preview for carbon-custom-elements ready! Built with commit 9b2bbaa https://deploy-preview-230--carbon-custom-elements.netlify.com |
cal-smith
approved these changes
Dec 16, 2019
|
My apologies again @cal-smith - It isn't documented and the Babel plugin may better handle setter-only declared properties. Just noticed the build error (the Babel plugin threw) when I was doing integration tests of CodeSandbox examples with the latest code. |
asudoh
added a commit
to asudoh/carbon-custom-elements
that referenced
this pull request
Dec 17, 2019
This change to React wrapper Babel plugin makes it support setter-only declared properties or one whose setter is defined first. Refs carbon-design-system#230.
asudoh
added a commit
that referenced
this pull request
Jan 6, 2020
This change to React wrapper Babel plugin makes it support setter-only declared properties or one whose setter is defined first. Refs #230.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
<bx-number-input>code support the Babel plugin that generates its React wrapper, by putting the getters of declared properties before their setters.This change also ensures that failures in such Babel plugin causes CI error.
My apologies for not catching this earlier @cal-smith 馃檱