fix(number-input): fix for React

gulp-tasks/build.js

@@ -18,14 +18,12 @@ const filter = require('gulp-filter');
 const sourcemaps = require('gulp-sourcemaps');
 const babel = require('gulp-babel');
 const sass = require('gulp-sass');
-const plumber = require('gulp-plumber');
 const postcss = require('gulp-postcss');
 const cleanCSS = require('gulp-clean-css');
 const prettier = require('gulp-prettier');
 const typescript = require('gulp-typescript');
 const header = require('gulp-header');
 const through2 = require('through2');
-const log = require('fancy-log');
 const stripComments = require('strip-comments');
 const autoprefixer = require('autoprefixer');
 const rtlcss = require('rtlcss');
@@ -78,7 +76,6 @@ const cssStream = ({ banner, dir }) =>
     )
     .pipe(prettier())
     .pipe(header(banner))
-    .on('error', log)
     .pipe(gulp.dest(path.resolve(config.jsDestDir)));
 
 module.exports = {
@@ -118,7 +115,6 @@ module.exports = {
       await promisifyStream(() =>
         gulp
           .src([`${config.srcDir}/components/**/*.ts`, `!${config.srcDir}/**/*-story*.ts*`, `!${config.srcDir}/**/stories/*.ts`])
-          .pipe(plumber())
           .pipe(
             babel({
               babelrc: false,
@@ -133,7 +129,6 @@ module.exports = {
           )
           .pipe(prettier())
           .pipe(header(banner))
-          .on('error', log)
           .pipe(gulp.dest(`${config.jsDestDir}/components-react`))
       );
     },
@@ -149,7 +144,6 @@ module.exports = {
             `!${config.srcDir}/**/*.d.ts`,
             `!${config.srcDir}/index-with-polyfills.ts`,
           ])
-          .pipe(plumber())
           .pipe(sourcemaps.init())
           .pipe(
             babel({
@@ -181,7 +175,6 @@ module.exports = {
           )
           // Avoids generating `.js` from interface-only `.ts` files
           .pipe(filter(file => stripComments(file.contents.toString(), { sourceType: 'module' }).replace(/\s/g, '')))
-          .on('error', log)
           .pipe(sourcemaps.write('.'))
           .pipe(gulp.dest(config.jsDestDir))
       );
@@ -196,7 +189,6 @@ module.exports = {
           `!${config.srcDir}/**/*-story*.ts*`,
           `!${config.srcDir}/**/stories/**/*.ts*`,
         ])
-        .pipe(plumber())
         .pipe(sourcemaps.init())
         .pipe(tsProject());
       return dts

package.json

@@ -116,7 +116,6 @@
     "eslint-plugin-prettier": "^3.0.0",
     "eslint-plugin-react": "^7.14.0",
     "eslint-restricted-globals": "^0.2.0",
-    "fancy-log": "^1.3.0",
     "flatpickr": "4.6.1",
     "globby": "^10.0.0",
     "gulp": "^4.0.0",
@@ -126,7 +125,6 @@
     "gulp-filter": "^6.0.0",
     "gulp-header": "^2.0.0",
     "gulp-jsdoc3": "^1.0.0",
-    "gulp-plumber": "^1.2.0",
     "gulp-postcss": "^8.0.0",
     "gulp-prettier": "^2.1.0",
     "gulp-sass": "^4.0.0",

src/components/number-input/number-input.ts

@@ -50,38 +50,38 @@ export default class BXNumberInput extends BXInput {
    * The minimum value allowed in the input
    */
   @property({ reflect: true })
-  set min(value) {
-    this._min = value;
-  }
-
   get min() {
     return this._min.toString();
   }
 
+  set min(value) {
+    this._min = value;
+  }
+
   /**
    * The maximum value allowed in the input
    */
   @property({ reflect: true })
-  set max(value) {
-    this._max = value;
-  }
-
   get max() {
     return this._max.toString();
   }
 
+  set max(value) {
+    this._max = value;
+  }
+
   /**
    * The amount the value should increase or decrease by
    */
   @property({ reflect: true })
-  set step(value) {
-    this._step = value;
-  }
-
   get step() {
     return this._step.toString();
   }
 
+  set step(value) {
+    this._step = value;
+  }
+
   /**
    * Set to `true` to enable the mobile variant of the number input
    */