Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

chore(github-actions): improve GA logic #753

Merged
merged 2 commits into from Nov 5, 2021
Merged

chore(github-actions): improve GA logic #753

merged 2 commits into from Nov 5, 2021

Conversation

Tansito
Copy link
Contributor

@Tansito Tansito commented Nov 5, 2021

Description

Whit this change the check for forks in GAs is more dynamic.

As a bonus in Qiskit we are adding a check to avoid the execution for some GAs with drafts too github.event.pull_request.draft == false just in case you could be interested.

@Tansito Tansito requested a review from a team as a code owner November 5, 2021 13:53
@Tansito Tansito requested review from ariellalgilmore, IgnacioBecerra and DragosRistici and removed request for a team November 5, 2021 13:53
jeffchew
jeffchew approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, thank you!

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/753/index.html

Built with commit: 0032b3bbb892200b9a09cd4318a37029393a34c7

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/753/index.html

Built with commit: 0032b3bbb892200b9a09cd4318a37029393a34c7

@jeffchew jeffchew changed the title Improve GA logic chore(github-actions): improve GA logic Nov 5, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/753/index.html

Built with commit: 0032b3bbb892200b9a09cd4318a37029393a34c7

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/753/index.html

Built with commit: 68b8b1e7b540983ada27a6579b07af43f56e3fa3

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 5, 2021
@jeffchew jeffchew mentioned this pull request Nov 5, 2021
Closed
@kodiakhq kodiakhq bot merged commit 1a2f61a into carbon-design-system:master Nov 5, 2021
@Tansito Tansito deleted the improve-ga branch November 5, 2021 23:41
Tansito pushed a commit to Tansito/carbon-web-components that referenced this pull request Nov 11, 2021
Revert "chore: make the forks check dynamic (carbon-design-system#753)"
7760a1c 
This reverts commit 1a2f61a.
kodiakhq bot added a commit that referenced this pull request Nov 12, 2021
@Tansito @kodiakhq
Revert "chore: make the forks check dynamic (#753)" (#789)
013259f 
This reverts commit 1a2f61a.

Co-authored-by: David García <david.garcia.valinas@ibm.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@DragosRistici DragosRistici Awaiting requested review from DragosRistici DragosRistici was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tansito @ibmdotcom-bot @jeffchew