Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[content] update UI icon production guidance #1600

Conversation

conradennis
Copy link
Contributor

updating production guidance to match updates on IDL. PR for changes to IDL UI icon production guidance: carbon-design-system/design-language-website#700

Changelog

Removed

  • mention of 16px icons and exporting from Sketch section

updating production guidance to match updates on IDL
@conradennis conradennis requested a review from a team August 21, 2020 18:25
@conradennis conradennis requested a review from a team as a code owner August 21, 2020 18:25
@vercel
Copy link

vercel bot commented Aug 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/im9w9x9lq
✅ Preview: https://carbondesignsy-git-fork-conradennis-update-ui-icon-produ-4c1f14.carbon-design-system.vercel.app

src/pages/guidelines/icons/contribute.mdx Outdated Show resolved Hide resolved
@@ -39,8 +39,8 @@ guidelines to ensure visual consistency and proper formatting.

## Making an icon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will want to check and update the IDL site because for this same section, the anchor link is incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the heads up!

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview August 26, 2020 00:37 Inactive
@kodiakhq kodiakhq bot merged commit 3252e31 into carbon-design-system:master Aug 26, 2020
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* update UI icon production guidance

updating production guidance to match updates on IDL

* Update src/pages/guidelines/icons/contribute.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

Co-authored-by: Andrea N. Cardona <andreancardona@gmail.com>
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* update UI icon production guidance

updating production guidance to match updates on IDL

* Update src/pages/guidelines/icons/contribute.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

Co-authored-by: Andrea N. Cardona <andreancardona@gmail.com>
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants