fix(type): update heading-03 line-height #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/o9y54nee0 |
joshblack
approved these changes
Aug 24, 2020
andreancardona
approved these changes
Aug 31, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
|
Hey @joshblack not sure what I'm doing wrong... I'm trying to change all the scale(5) type line height in the .json file. It should be 24px / 30px line height. But in the preview link it doesn't look like it changed at all. And when I inspect, it still says 125% for the line height, which is what is says on the site currently.
|
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1604
Changelog
Changed
heading-03line-height values to what exists in codeReviewing
@jeanservaas if you could just verify that the rest of the line-height values are correct for the table, I have another PR up using the values directly from the website (carbon-design-system/carbon#6711)