Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status indicator pattern #2294

Merged

Conversation

jeanservaas
Copy link
Contributor

@jeanservaas jeanservaas commented May 7, 2021

TO DO:

  • @vpicone add the tables (# feature[patterns]:modified table for status indicator pattern #2199)
  • @janchild quick content review (with an eye to naming... I think that's the most awkward thing about the pattern content-wise the (Full status indicator, Badge status indicator, Shape status indicator and Differential status indicator) — that's what I most want your opinion on. Don't bother with the Notion document anymore except for the tables.

Closes # #2199

ADDITIONS:
Sorry vince, I don't have an issue for this, I thought I could handle it in markdown but I cannot.

image

Light values

image

Dark values

image

  • I also need to enter the yellow and orange values into the palette component, but I do not need it to have tabs... it doesn't have separate dark and light values.

image

image

@jeanservaas jeanservaas requested review from vpicone, janchild and a team May 7, 2021 21:08
@jeanservaas jeanservaas requested a review from a team as a code owner May 7, 2021 21:08
@vercel
Copy link

vercel bot commented May 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/AxVFzv3kCZNAFyYWq2XjvGFSqogd
✅ Preview: https://carbondesignsy-git-fork-jeanservaas-docs-status-indicato-464d92.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

DCO Assistant Lite bot All contributors have signed the DCO.

@vpicone
Copy link
Contributor

vpicone commented May 10, 2021

Looks good to me, why don't we remove the nav-items entry so we can 'soft' ship this. Then I'll add the sidenav entry when I add the tables.

We might want to be more explicit than using equal symbols under accessibility? https://carbondesignsystem-kv8avyeky-carbon-design-system.vercel.app/patterns/status-indicator-pattern/#accessibility

@jeanservaas
Copy link
Contributor Author

@vpicone here are the assets for all the tables. I still need to consult @janchild about a couple of content issues... I'm not sure how useful this page would be without the tables anyway.

Status_icons.zip

@vpicone
Copy link
Contributor

vpicone commented May 10, 2021

@jeanservaas that's the idea behind removing it from the nav-items. We can publish the page without surfacing it in the side nav until the tables are ready.

Full copy edit and revision.
@vpicone
Copy link
Contributor

vpicone commented May 18, 2021

@jeanservaas I temporarily removed the entry from the sidebar. When it's ready we can "soft launch" it and I can open a new PR for the tables.

Reviewers: You can still see the page by manually adding /patterns/status-indicator-pattern/ to the URL.

@jeanservaas
Copy link
Contributor Author

@vpicone can you put back the .yaml file on the status indicator page? We’re not going to soft launch it, there’s really no point in a soft launch without the tables and colors in there

@vpicone
Copy link
Contributor

vpicone commented May 19, 2021

Copy pasting from slack: The reason is so that I can create a fresh PR with new reviewers for the code. There’s no harm in publishing it, it’s not like people are going to randomly type in the exact URL. And if they do, there’s not nuclear launch codes, it’s just under construction.

For reviewers, you can access the new page here:
https://carbondesignsy-git-fork-jeanservaas-docs-status-indicato-464d92.vercel.app/patterns/status-indicator-pattern/

@jeanservaas
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@vpicone
Copy link
Contributor

vpicone commented Jun 1, 2021

Made a new issue to finish this off here: #2366

@vpicone vpicone merged commit 242be17 into carbon-design-system:main Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants