Skip to content

Commit

Permalink
fix(modal): add aria attributes (#1036)
Browse files Browse the repository at this point in the history
Fixes #986.
  • Loading branch information
asudoh authored and alisonjoseph committed Aug 22, 2018
1 parent 4992750 commit a926d84
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/components/modal/modal.hbs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<button class="bx--btn {{classPrimaryButton}}" type="button" data-modal-target="#modal-{{idSuffix}}">Show modal</button>

<div data-modal id="modal-{{idSuffix}}" class="bx--modal {{classModalSupplemental}}" tabindex="-1">
<div data-modal id="modal-{{idSuffix}}" class="bx--modal {{classModalSupplemental}}" role="dialog" aria-modal="true" aria-labelledby="modal-{{idSuffix}}-label" aria-describedby="modal-{{idSuffix}}-heading" tabindex="-1">
<div class="bx--modal-container">
<div class="bx--modal-header">
<p class="bx--modal-header__label bx--type-delta">Optional label</p>
<p class="bx--modal-header__heading bx--type-beta">Modal heading</p>
<p class="bx--modal-header__label bx--type-delta" id="modal-{{idSuffix}}-label">Optional label</p>
<p class="bx--modal-header__heading bx--type-beta" id="modal-{{idSuffix}}-heading">Modal heading</p>
<button class="bx--modal-close" type="button" data-modal-close aria-label="close modal" {{#unless hasFooter}} data-modal-primary-focus{{/unless}}>
<svg class="bx--modal-close__icon" width="10" height="10" viewBox="0 0 10 10" xmlns="http://www.w3.org/2000/svg">
<title>Close Modal</title>
Expand Down

0 comments on commit a926d84

Please sign in to comment.