Skip to content

Commit

Permalink
fix(NumberInput): set negative tabindex on number controls (#8090)
Browse files Browse the repository at this point in the history
* refactor(NumberInput): remove unneeded aria-live and aria-atomic attrs

* fix(NumberInput): set negative tabindex on number controls

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
emyarod and kodiakhq[bot] committed Mar 17, 2021
1 parent a0812ed commit e342c5a
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions packages/react/src/components/NumberInput/NumberInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -469,8 +469,7 @@ class NumberInput extends Component {
onClick={(evt) => this.handleArrowClick(evt, 'down')}
title={decrementNumLabel || iconDescription}
aria-label={decrementNumLabel || iconDescription}
aria-live="polite"
aria-atomic="true">
tabIndex="-1">
<Subtract16 className="down-icon" />
</button>
<div className={`${prefix}--number__rule-divider`}></div>
Expand All @@ -481,8 +480,7 @@ class NumberInput extends Component {
onClick={(evt) => this.handleArrowClick(evt, 'up')}
title={incrementNumLabel || iconDescription}
aria-label={incrementNumLabel || iconDescription}
aria-live="polite"
aria-atomic="true">
tabIndex="-1">
<Add16 className="up-icon" />
</button>
<div className={`${prefix}--number__rule-divider`}></div>
Expand Down

0 comments on commit e342c5a

Please sign in to comment.