Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<GVT><non-EN> Hardcode string "Loading" shows in loading component #4194

Closed
reeteshsingh93 opened this issue Oct 3, 2019 · 9 comments
Closed
Assignees
Labels
severity: 3 User can complete task, and/or has a workaround status: help wanted 👐 type: a11y ♿ version: 9 Issues pertaining to legacy Carbon

Comments

@reeteshsingh93
Copy link

Environment

Operating system

Mac OS MOjave

Browser

FIrefox

Automated testing tool and ruleset
N.A
Assistive technology used to verify

Detailed description

What version of the Carbon Design System are you using?
"carbon-components": "9.57.0",
"carbon-components-react": "6.115.1",
What did you expect to happen?
Should display localized text as per the borwser settings
What happened instead?
display text in english
What WCAG 2.1 checkpoint does the issue violate?

Steps to reproduce the issue

  1. Step one

Render component on any page
2. Step two
Change the browser local to chinese
3. Step three
hover over the component text will appear in english.
4. etc.

Please create a reduced test case in CodeSandbox

Additional information

  • Screenshots or code

image

  • Notes
@asudoh
Copy link
Contributor

asudoh commented Oct 3, 2019

Hi 👋 thank you for reporting! Feel free to create a backport PR of: #2955

@emyarod emyarod self-assigned this Oct 8, 2019
@dakahn dakahn added version: 9 Issues pertaining to legacy Carbon priority: low severity: 3 User can complete task, and/or has a workaround labels Oct 15, 2019
@reeteshsingh93
Copy link
Author

I don't have access to org for raising a PR:

image

@reeteshsingh93
Copy link
Author

@asudoh @emyarod Please suggest..

@emyarod
Copy link
Member

emyarod commented Oct 22, 2019

@reeteshsingh93 there is already an open PR carbon-design-system/carbon-components-react#2421 but is it possible your credentials or your remote are incorrect?

@asudoh
Copy link
Contributor

asudoh commented Oct 22, 2019

@reeteshsingh93 Our process for creating PR is creating a PR from a fork, instead of directory to this repo. Thanks!

@reeteshsingh93
Copy link
Author

@emyarod Are you plainning to merge that PR? and will it resolve issue in "carbon-components-react": "6.115.1" after it get merged?

@reeteshsingh93
Copy link
Author

@asudoh Ok will raise it that way if required.

@emyarod emyarod closed this as completed Oct 29, 2019
@emyarod
Copy link
Member

emyarod commented Oct 29, 2019

it will be in v6.116.2

@reeteshsingh93
Copy link
Author

@emyarod Thanks for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity: 3 User can complete task, and/or has a workaround status: help wanted 👐 type: a11y ♿ version: 9 Issues pertaining to legacy Carbon
Projects
None yet
Development

No branches or pull requests

4 participants