fix(Loading): use description prop as SVG title #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
added this to In progress
in v10 enhancements, tech debt, new features
via automation
|
Deploy preview for the-carbon-components ready! Built with commit aefdb94 https://deploy-preview-2955--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit aefdb94 |
|
Deploy preview for carbon-components-react failed. Built with commit aefdb94 https://app.netlify.com/sites/carbon-components-react/deploys/5cf9315a5145cb0008028033 |
dakahn
approved these changes
Jun 6, 2019
v10 enhancements, tech debt, new features
automation
moved this from In progress
to Reviewer approved
Jun 6, 2019
v10 enhancements, tech debt, new features
automation
moved this from Reviewer approved
to Done
Jun 6, 2019
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jun 11, 2019
…#2955) * fix(Loading): use description prop as SVG title * docs(Loading): expose icon description props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2954
This PR passes the
descriptionprop to the<Loading>component SVG titleTesting / Reviewing
Ensure the SVG title reflects the
iconDescriptionprop in<InlineLoading>and thedescriptionprop in<Loading>