This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
fix(Loading): use description prop as SVG title #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpicone
suggested changes
Oct 17, 2019
| /** | ||
| * Specify the description for the inline loading text | ||
| */ | ||
| iconDescription: PropTypes.string, |
There was a problem hiding this comment.
What's the difference between this and description? Can we just use description instead of adding a new prop? Looks like you might have accidentally not updated the comment block
There was a problem hiding this comment.
description is meant to be a node instead of a string, and iconDescription is for the SVG title in <Loading />
emyarod
force-pushed
the
4194-support-custom-loading-svg-titles
branch
2 times, most recently
from
b93281f
to
869cf45
Compare
emyarod
force-pushed
the
4194-support-custom-loading-svg-titles
branch
from
869cf45
to
d2e6312
Compare
|
@vpicone Would you be able to re-review? Thanks! |
vpicone
approved these changes
Oct 25, 2019
|
until v8 is released I imagine |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes carbon-design-system/carbon#4194 (backport of carbon-design-system/carbon#2955)
This PR passes the
descriptionprop to the<Loading>component SVG titleTesting / Reviewing
Ensure the SVG title reflects the
iconDescriptionprop in<InlineLoading>and thedescriptionprop in<Loading>