Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): remove field-disabled, layer-disabled tokens #10535

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Jan 26, 2022

Closes #9832
Related #10292 (comment)

These were missed in the original PR for #9832.

Changelog

Changed

  • migrate usages of $field-disabled to use $field
  • migrate usages of $layer-disabled to use $layer

Removed

  • theme: remove field-disabled and layer-disabled tokens

Testing / Reviewing

  • "Find all" search in the repo for each field-disabled, fieldDisabled, layer-disabled, layerDisabled should return no results.
  • Take a look at stories for components impacted to ensure usage is valid:
    • text input
    • search
    • select
    • number input
    • date picker
    • dropdown
    • text area

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating!

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 27b649f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f32253b99c340007fbeb50

😎 Browse the preview: https://deploy-preview-10535--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 27b649f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f32254e89d45000796595d

😎 Browse the preview: https://deploy-preview-10535--carbon-components-react.netlify.app/

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 27b649f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f32253a8f9df0007f2e98a

😎 Browse the preview: https://deploy-preview-10535--carbon-elements.netlify.app

@kodiakhq kodiakhq bot merged commit e791900 into carbon-design-system:main Jan 27, 2022
tay1orjones added a commit to jnm2377/carbon that referenced this pull request Jan 31, 2022
Mirroring the update from carbon-design-system#10535, $layer-disabled no longer exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Token "field-disabled" not involved into layering model
5 participants