Tanner update playgrounds v2 #12256
Merged
Tanner update playgrounds v2 #12256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
TannerS
commented
Oct 9, 2022
abbeyhrt
reviewed
Oct 14, 2022
abbeyhrt
reviewed
Oct 14, 2022
abbeyhrt
previously requested changes
Oct 14, 2022
Co-authored-by: Abbey Hart <abbeyhrt@gmail.com>
Co-authored-by: Abbey Hart <abbeyhrt@gmail.com>
Co-authored-by: Abbey Hart <abbeyhrt@gmail.com>
|
updated |
TannerS
requested review from
tw15egan,
tay1orjones and
abbeyhrt
and removed request for
tw15egan and
tay1orjones
tw15egan
reviewed
Oct 27, 2022
| type: 'object', | ||
| }, | ||
| }, | ||
| light: { |
There was a problem hiding this comment.
Can we hide this prop, as it is deprecated and should no longer be used
tw15egan
reviewed
Oct 27, 2022
| @@ -61,3 +61,20 @@ export const Nested = () => { | |||
| }; | |||
|
|
|||
| Nested.storyName = 'nested'; | |||
|
|
|||
There was a problem hiding this comment.
Should this file be renamed to UnorderedList.stories.js ?
|
@TannerS just left a few more comments 👍🏻 |
TannerS
requested review from
tw15egan and
tay1orjones
and removed request for
abbeyhrt and
tw15egan
tw15egan
approved these changes
Oct 27, 2022
tay1orjones
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12251
Closes #12250
Closes #12250
Closes #12249
This is attempt to work on the following playgrounds
I am not sure i did them all 100% correct but what I attempted is...
for any files that existed in both the root and next folder, i just moved the file and overwrote it (I hope that is correct or else ill make a new branch/pr and do it right)
IF any of this is incorrect i will prob remake the PR since reverting changes is much harder, but im under the assumption of one story from the next folder, please correct me if im wrong
Testing / Reviewing
Verified in storybook
NEED HELP
One thing i did and can't figure out how to fix, if I could get some help on this?
cc: @abbeyhrt @aledavila