Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): generate notification tokens #12344

Merged
merged 18 commits into from
Oct 27, 2022

Conversation

abbeyhrt
Copy link
Contributor

Closes #11949

This PR includes the changes to tag but those can be ignored. They will be reviewed in #12333

Generates tokens for notifications.

I wanted to get this in PR

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

Verify that the components look the same! Especially for lowContrast mode since I don't think those have VRT snapshots.

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 939ca32
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/635ae89b60559e0007a2ed52
😎 Deploy Preview https://deploy-preview-12344--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 939ca32
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/635ae89b09548e000818a20e
😎 Deploy Preview https://deploy-preview-12344--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed an update for snaps. LGTM, though as you said we should wait to merge until the tag PR has been merged in.

@tay1orjones
Copy link
Member

Tag PR is in, this one should be good to go

@kodiakhq kodiakhq bot merged commit b29b3b3 into carbon-design-system:main Oct 27, 2022
@carbon-bot
Copy link
Contributor

Hey there! v11.16.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Export color codes (hex/rgba) for Component colors
5 participants