-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(themes): generate notification tokens #12344
feat(themes): generate notification tokens #12344
Conversation
…at/export-color-component
…carbon-fork-1 into feat/export-color-component
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed an update for snaps. LGTM, though as you said we should wait to merge until the tag PR has been merged in.
Tag PR is in, this one should be good to go |
Hey there! v11.16.0 was just released that references this issue/PR. |
Closes #11949
This PR includes the changes to
tag
but those can be ignored. They will be reviewed in #12333Generates tokens for notifications.
I wanted to get this in PR
Changelog
New
Changed
Removed
Testing / Reviewing
Verify that the components look the same! Especially for lowContrast mode since I don't think those have VRT snapshots.