Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(project): move add-to-project job into a separate workflow #12659

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Nov 15, 2022

This moves the add-to-project job into its own workflow file. This way we can more granularly control when it's ran.

In the previous set up, if you had removed an issue from the project and then commented on the issue, the workflow would run again moving it back into the project.

With this change, issues will be automatically added to the project only when the issue is created or labelled.

Changelog

New

  • add add-to-project workflow file

Removed

  • removed add-to-project from issue triage workflow file

@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c9fdaa1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6389446614c51600093bd60c
😎 Deploy Preview https://deploy-preview-12659--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c9fdaa1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63894466059d120008a1ec82
😎 Deploy Preview https://deploy-preview-12659--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Comment on lines +16 to +24
add-to-proposals-project:
name: Add issue with enhancement label to the Proposals project
runs-on: ubuntu-latest
steps:
- uses: actions/add-to-project@v0.4.0
with:
labeled: ${{ env.LABEL_ENHANCEMENT }}
project-url: ${{ env.PROPOSALS_PROJECT_URL }}
github-token: ${{ secrets.ADD_TO_PROJECT_PAT }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sstrubberg Based on our conversations yesterday, I just added this here that will add issues with the type: enhancement 💡 label to the Proposals project. These will no longer be added to the Design System project by default. Let me know what you think!

@kodiakhq kodiakhq bot merged commit 2551cd5 into carbon-design-system:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants