Skip to content

Commit

Permalink
fix(search): AVT1 bugs (#1416)
Browse files Browse the repository at this point in the history
* fix(search): change aria-labelledby to correct id

* fix(search): remove redundant aria roles from wrapper divs

* fix(searhc): move aria landmark role from input to wrapper div

* fix(search): remove redundant aria labelling
  • Loading branch information
dakahn authored and alisonjoseph committed Nov 13, 2018
1 parent 3e89adc commit d605483
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/components/search/search.hbs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{{#is suffix "sm"}}
<div class="bx--form-item">{{/is}}
<div data-search class="bx--search bx--search--{{suffix}}{{#if light}} bx--search--light{{/if}}" role="search">
<div data-search role="search" class="bx--search bx--search--{{suffix}}{{#if light}} bx--search--light{{/if}}">
<label id="search-input-label-1" class="bx--label" for="search__input-1">Search</label>
<input class="bx--search-input" type="text" role="search" id="search__input-1" placeholder="Search" aria-labelledby="search-input-label-2">
<input class="bx--search-input" type="text" id="search__input-1" placeholder="Search">
<svg class="bx--search-magnifier" width="16" height="16" viewBox="0 0 16 16">
<path d="M6.5 12a5.5 5.5 0 1 0 0-11 5.5 5.5 0 0 0 0 11zm4.936-1.27l4.563 4.557-.707.708-4.563-4.558a6.5 6.5 0 1 1 .707-.707z"
fill-rule="nonzero" />
Expand Down

0 comments on commit d605483

Please sign in to comment.