Added trap focus and focus redirection #14877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
reviewed
Oct 18, 2023
…nto 14691-a11y-notification
tw15egan
added
status: ready for review 👀
status: one more review 👀
and removed
status: merge conflict 🚫
labels
tay1orjones
approved these changes
Nov 3, 2023
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
carbon-design-system:main
with commit Nov 8, 2023
6d2b92c
21 checks passed
2 tasks
2 tasks
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
* fix: added trap focus and focus redirection * test: added test to match tabIndex * fix: fixed focus issues to action button * chore: remove test story * fix: fixed test * fix: fixed avt test to match component --------- Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: Taylor Jones <taylor.jones826@gmail.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14691
Enhanced the ActionableNotification component by implementing trap focus functionality, alongside the addition of a tabIndex attribute to the parent div. This enhancement ensures that when a user receives a notification with the hasFocus prop set to true, the focus is correctly directed to the component.
Changelog
New
tabIndexin the parent div.Testing / Reviewing
TestFocusvariantTestFocusvariant