Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification]: Investigate deprecating hasFocus prop #15534

Closed
2 tasks
tay1orjones opened this issue Jan 12, 2024 · 0 comments · Fixed by #15571
Closed
2 tasks

[Notification]: Investigate deprecating hasFocus prop #15534

tay1orjones opened this issue Jan 12, 2024 · 0 comments · Fixed by #15571
Assignees
Labels
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jan 12, 2024

I think we actually need to deprecate hasFocus - the spec for alertdialog states that focus should always be given to a focusable element within the dialog. This originally came up in slack

In #14877, focus wrap behavior was implemented for the ActionableNotification. I think it was a slight oversight to leave hasFocus in. Even with hasFocus off, I believe the wrapFocus() helper always focuses the currentActiveElement that is passed in.

Even if it doesn't, this prop should be deprecated because the spec states that focus should always move to the alertdialog.

  • Deprecate the hasFocus prop
  • Ensure focus always moves to the ActionableNotification

I think many of the use cases previously using ActionableNotification hasFocus="false" should actually use StaticNotification once it's available, #15532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants