fix: 15327-incorrect-padding-sizes #15551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
reviewed
Jan 17, 2024
Comment on lines
+104
to
+105
| padding-block: 1rem; | ||
| padding-block-end: 1.5rem; |
There was a problem hiding this comment.
We can just combine these in the padding-block definition 👍🏻
Suggested change
| padding-block: 1rem; | |
| padding-block-end: 1.5rem; | |
| padding-block: 1rem 1.5rem; |
There was a problem hiding this comment.
@riddhybansal You can commit the suggestion directly in the "Commit suggestion" or push a new commit to address the changes TJ posted it
tw15egan
approved these changes
Jan 17, 2024
Merged
via the queue into
carbon-design-system:main
with commit Feb 6, 2024
9479afd
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15327
There were inconsistent padding in data tables.
Changelog
Changed
Testing / Reviewing
The guidance from figma designs states that the expandable panel needs 16px padding-top and 24px padding-bottom and this should be consistent in all sizes.