Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 15327-incorrect-padding-sizes #15551

Merged
merged 2 commits into from Feb 6, 2024
Merged

fix: 15327-incorrect-padding-sizes #15551

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe96486
fix: 1532-incorrect-padding-sizes
riddhybansal Jan 9, 2024
e4cf9fe
Merge branch 'main' into 15327-incorrect-expandable-padding
tw15egan Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/styles/scss/components/data-table/expandable/_data-table-expandable.scss
View file
Open in desktop
Expand Up @@ -101,6 +101,8 @@
td
.#{$prefix}--child-row-inner-container {
max-block-size: 100%;
padding-block: 1rem;
padding-block-end: 1.5rem;
Comment on lines +104 to +105
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just combine these in the padding-block definition 👍🏻

Suggested change
padding-block: 1rem;
padding-block-end: 1.5rem;
padding-block: 1rem 1.5rem;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riddhybansal You can commit the suggestion directly in the "Commit suggestion" or push a new commit to address the changes TJ posted it

}

// bottom border overrides
Expand Down