Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added hasFocus as deprecated prop #15571

Merged
merged 5 commits into from Jan 26, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jan 19, 2024

Closes #15534

Deprecating hasFocus because we are gonna have a new variant in the future called StaticNotification to avoid confusion around the usage of the ActionableNotification.

Changed

  • hasFocus prop is deprecated
  • Removed hasFocus prop from Default and Playground stories

Testing / Reviewing

  • Ensure focus always moves to the ActionableNotification

@guidari guidari requested a review from a team as a code owner January 19, 2024 15:10
Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e8bcd3b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65aa90ee3233840008196884
😎 Deploy Preview https://deploy-preview-15571--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ac97cfa
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65aacbc420ca4e0008f3917c
😎 Deploy Preview https://deploy-preview-15571--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari requested a review from a team as a code owner January 19, 2024 19:21
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@guidari guidari added this pull request to the merge queue Jan 26, 2024
Merged via the queue into carbon-design-system:main with commit cb499c0 Jan 26, 2024
21 of 22 checks passed
@guidari guidari deleted the 15534-hasfocus branch January 26, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notification]: Investigate deprecating hasFocus prop
3 participants