feat: added dividers accross multiple states for AI select #15952
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Hey @riddhybansal LGTM 🚀
Just on thing in the Select component
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
A few other questions I just thought of:
|
@alina-jacob could you help answer this? The spec only refers to horizontal spacing, so I think the existing solution would work for all sizes if the values should be the same on every size. |
Hi @tay1orjones you're right, the spacing stays the same across large, medium and small sizes. |
|
Confirmed styles work across all sizes
|
|
|
||
| .#{$prefix}--select--slug .#{$prefix}--slug::before { | ||
| display: none; | ||
| inset-inline-start: convert.to-rem(-9px); |
There was a problem hiding this comment.
| inset-inline-start: convert.to-rem(-9px); | |
| inset-inline-start: calc(-#{$spacing-03} - 1px); |
In the spirit of @tay1orjones PR around magic numbers, would we want to update these values to be the padding value plus the divider size?
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
5bd4f4a
…sign-system#15952) * feat: added dividers accross multiple states for AI select * fix: some styles * fix: some styles * fix: styling with magic numbers --------- Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
Closes #15860
Added dividers accross multiple states for AI select
Changelog
New
Testing / Reviewing