Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added dividers accross multiple states for AI select #15952

Merged
merged 7 commits into from Apr 3, 2024
Merged

feat: added dividers accross multiple states for AI select #15952

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0bf8cc6
feat: added dividers accross multiple states for AI select
riddhybansal Mar 13, 2024
7cba5d0
fix: some styles
riddhybansal Mar 13, 2024
f5b5672
fix: some styles
riddhybansal Mar 18, 2024
ef6ad2e
fix: styling with magic numbers
riddhybansal Apr 3, 2024
9317a6e
Merge branch 'main' into Introduce_Divider_across_multiple_states_for…
tay1orjones Apr 3, 2024
3f1c3fc
Merge branch 'main' into Introduce_Divider_across_multiple_states_for…
tw15egan Apr 3, 2024
fd2bc32
Merge branch 'main' into Introduce_Divider_across_multiple_states_for…
andreancardona Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
48 changes: 40 additions & 8 deletions packages/styles/scss/components/select/_select.scss
View file
Open in desktop
Expand Up @@ -281,30 +281,62 @@
}

// Slug styles

$divider-width: 1px;

.#{$prefix}--select--slug .#{$prefix}--slug {
position: absolute;
inset-block-start: 50%;
inset-inline-end: $spacing-08;
inset-inline-end: calc($spacing-08 + 8px + $divider-width);
margin-block-start: convert.to-rem(0.5px);
transform: translateY(-50%);
}

.#{$prefix}--select--slug .#{$prefix}--slug::after,
.#{$prefix}--select--slug .#{$prefix}--slug::before {
position: absolute;
background-color: $border-subtle-01;
block-size: convert.to-rem(16px);
content: '';
inline-size: convert.to-rem(1px);
}

.#{$prefix}--select--slug .#{$prefix}--slug::before {
display: none;
inset-inline-start: calc(-#{$spacing-03} - #{$divider-width});
}

.#{$prefix}--select--slug .#{$prefix}--slug::after {
display: block;
inset-inline-end: calc(-#{$spacing-03} - #{$divider-width});
}

.#{$prefix}--select--slug
.#{$prefix}--select-input:not(:has(~ .#{$prefix}--slug--revert)) {
@include ai-gradient;

padding-inline-end: $spacing-10;
}

.#{$prefix}--select--slug.#{$prefix}--select--invalid
.#{$prefix}--select-input,
.#{$prefix}--select--slug.#{$prefix}--select--warning
.#{$prefix}--select-input {
.#{$prefix}--select--slug:has(.#{$prefix}--select__invalid-icon)
.#{$prefix}--select-input:not(:has(~ .#{$prefix}--slug--revert)) {
padding-inline-end: $spacing-12;
}

.#{$prefix}--select--slug.#{$prefix}--select--invalid .#{$prefix}--slug,
.#{$prefix}--select--slug.#{$prefix}--select--warning .#{$prefix}--slug {
inset-inline-end: $spacing-10;
.#{$prefix}--select--slug:has(.#{$prefix}--select__invalid-icon)
.#{$prefix}--slug::before {
display: block;
}

.#{$prefix}--select--slug
.#{$prefix}--select-input__wrapper[data-invalid]
.#{$prefix}--select-input
~ .#{$prefix}--select__invalid-icon,
.#{$prefix}--select--slug
.#{$prefix}--select-input__wrapper
.#{$prefix}--select-input
~ .#{$prefix}--select__invalid-icon {
inset-inline-end: $spacing-11;
}

// Windows HCM fix
Expand Down