fix(15510): Update Interface to Include href Prop in SwitcherItem Type #16043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreancardona
approved these changes
Mar 25, 2024
2nikhiltom
changed the title
tay1orjones
requested changes
Mar 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Apr 1, 2024
599fbf0
20 checks passed
preetibansalui
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Apr 24, 2024
carbon-design-system#16043) * fix(15510): update switcherItem interface * Update SwitcherItem.tsx * fix(15510): update propType and href passed to Link * chore(15510): fix typo * chore: update snaps --------- Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15510
Added optional 'href' prop to
BaseSwitcherItemPropsfor link URLs.New
Added href prop to
BaseSwitcherItemPropsTesting / Reviewing
Test the usage of
SwitcherItemwith thehrefprop in a TypeScript environment within aSwitchercomponent. Verify that the TypeScript compiler should not throw error and the component renders without errors and correctly applies the providedhrefattribute