Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(15510): Update Interface to Include href Prop in SwitcherItem Type #16043

Merged
merged 11 commits into from
Apr 1, 2024
Merged

fix(15510): Update Interface to Include href Prop in SwitcherItem Type #16043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
323a10d
fix(15510): update switcherItem interface
2nikhiltom Mar 25, 2024
0a5399f
Update SwitcherItem.tsx
andreancardona Mar 25, 2024
edb37ba
fix(15510): update propType and href passed to Link
2nikhiltom Mar 27, 2024
f560868
Merge branch 'TS_error_href_prop' of https://github.com/2nikhiltom/ca…
2nikhiltom Mar 27, 2024
a52af31
chore(15510): fix typo
2nikhiltom Mar 27, 2024
3849730
Merge branch 'main' into TS_error_href_prop
2nikhiltom Mar 27, 2024
91bdc9a
chore: update snaps
2nikhiltom Mar 27, 2024
6fd5a6e
Merge branch 'main' into TS_error_href_prop
2nikhiltom Mar 27, 2024
3b8a24c
Merge branch 'main' into TS_error_href_prop
2nikhiltom Mar 28, 2024
c1e8545
Merge branch 'main' into TS_error_href_prop
2nikhiltom Mar 29, 2024
00b2e0f
Merge branch 'main' into TS_error_href_prop
2nikhiltom Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7482,6 +7482,9 @@ Map {
"handleSwitcherItemFocus": Object {
"type": "func",
},
"href": Object {
"type": "string",
},
"index": Object {
"type": "number",
},
Expand Down
10 changes: 10 additions & 0 deletions packages/react/src/components/UIShell/SwitcherItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ interface BaseSwitcherItemProps {
* Specify whether the panel is selected
*/
isSelected?: boolean;
/**
* Optionally provide an href for the underlying li`
*/
href?: string;
}

interface SwitcherItemWithAriaLabel extends BaseSwitcherItemProps {
Expand Down Expand Up @@ -75,6 +79,7 @@ const SwitcherItem = forwardRef<ElementType, SwitcherItemProps>(
index,
handleSwitcherItemFocus,
onKeyDown = () => {},
href,
...rest
} = props;

Expand Down Expand Up @@ -116,6 +121,7 @@ const SwitcherItem = forwardRef<ElementType, SwitcherItemProps>(
setTabFocus(evt);
onKeyDown(evt);
}}
href={href}
ref={forwardRef}
{...rest}
className={linkClassName}
Expand Down Expand Up @@ -143,6 +149,10 @@ SwitcherItem.propTypes = {
* event handlers
*/
handleSwitcherItemFocus: PropTypes.func,
/**
* Optionally provide an href for the underlying li`
*/
href: PropTypes.string,
/**
* Specify the index of the SwitcherItem
*/
Expand Down