Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date picker a11y bug #16219

Merged

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Apr 17, 2024

Closes #15251

Testing / Reviewing

  • Tab Focus to Range with Calendar
  • Hit escape
  • Focus should go back to the End date input as seen below
Screen.Recording.2024-04-17.at.10.09.06.mov

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit c06d5eb
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/667acce989cbda0008a53271
😎 Deploy Preview https://deploy-preview-16219--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@alisonjoseph alisonjoseph added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@tay1orjones tay1orjones added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@2nikhiltom 2nikhiltom added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@guidari guidari added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@guidari
Copy link
Contributor

guidari commented May 29, 2024

This PR doesn't want to get merged 🤔
Looks like we have the CI failing in the avt test

@guidari guidari added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@2nikhiltom 2nikhiltom requested a review from a team as a code owner June 19, 2024 12:27
@2nikhiltom 2nikhiltom requested a review from guidari June 19, 2024 12:27
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c06d5eb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/667acce9a33ca900086bc628
😎 Deploy Preview https://deploy-preview-16219--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari self-assigned this Jun 19, 2024
@tay1orjones tay1orjones added this pull request to the merge queue Jun 25, 2024
Merged via the queue into carbon-design-system:main with commit bff0000 Jun 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[a11y]: DatePicker [Range With Calendar] - focus order is incorrect
6 participants