-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(progress-indicator): design audit changes #2015
fix(progress-indicator): design audit changes #2015
Conversation
Deploy preview for the-carbon-components ready! Built with commit d6b3d95 https://deploy-preview-2015--the-carbon-components.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @jnm2377!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one last change: We need to make the type inside of the tooltip menu to be type style: body-long-01 and color token: inverse-01. Right now the line spacing is too cramped.
Also the overflow text is in Helvetica but I think that change is being tracked in another issue.
@laurenmrice just updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ! 👍
🎉 This PR is included in version 9.83.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #1976
.bx--progress-step--disabled
in the last<li>
. For some reason right now it's using disabled attribute instead of the class.current
should be