Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress-indicator): design audit changes #2015

Merged
merged 4 commits into from
Mar 8, 2019
Merged

fix(progress-indicator): design audit changes #2015

merged 4 commits into from
Mar 8, 2019

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Mar 7, 2019

Closes #1976

  • note: the carbon-components repo example shows the last state as disabled, the website html just needs to be updated to include the disabled class .bx--progress-step--disabled in the last <li>. For some reason right now it's using disabled attribute instead of the class.

current

<li class="bx--progress-step bx--progress-step--incomplete" disabled >
   ...
</li>

should be

<li class="bx--progress-step bx--progress-step--disabled" aria-disabled="true" >
   ...
</li>

@jnm2377 jnm2377 requested a review from laurenmrice March 7, 2019 20:01
@netlify
Copy link

netlify bot commented Mar 7, 2019

Deploy preview for the-carbon-components ready!

Built with commit d6b3d95

https://deploy-preview-2015--the-carbon-components.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @jnm2377!

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one last change: We need to make the type inside of the tooltip menu to be type style: body-long-01 and color token: inverse-01. Right now the line spacing is too cramped.

Also the overflow text is in Helvetica but I think that change is being tracked in another issue.

@asudoh asudoh added this to the v10.0-rc1 milestone Mar 7, 2019
@jnm2377
Copy link
Contributor Author

jnm2377 commented Mar 8, 2019

@laurenmrice just updated!

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design had to make some design changes for tooltip to align across the board for different components. The spacing and specs are included below.

Overflow step name:
artboard

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! 👍

@jnm2377 jnm2377 merged commit d9a8d16 into carbon-design-system:master Mar 8, 2019
@jnm2377 jnm2377 deleted the progress-audit-1976 branch March 8, 2019 19:45
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 9.83.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants