Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): update deprecate helper #3314

Merged

Conversation

joshblack
Copy link
Contributor

Our deprecate helper had a 🐛 and this updates it to work for multiple component types with multiple prop names, it also adds associated tests for these abilities.

Changelog

New

Changed

  • Update deprecate prop helper and add tests

Removed

@joshblack joshblack requested a review from a team July 9, 2019 17:12
@joshblack joshblack added this to the v10.4 milestone Jul 9, 2019
@ghost ghost requested review from emyarod and mattrosno and removed request for a team July 9, 2019 17:12
@netlify
Copy link

netlify bot commented Jul 9, 2019

Deploy preview for the-carbon-components ready!

Built with commit 702eabf

https://deploy-preview-3314--the-carbon-components.netlify.com

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod merged commit d62ac2b into carbon-design-system:master Jul 9, 2019
@netlify
Copy link

netlify bot commented Jul 9, 2019

Deploy preview for carbon-components-react ready!

Built with commit 702eabf

https://deploy-preview-3314--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jul 9, 2019

Deploy preview for carbon-elements ready!

Built with commit 702eabf

https://deploy-preview-3314--carbon-elements.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants