fix(content-switcher): set height in button container instead of button #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest code that dictates the height of content switcher buttons is introduced in carbon-design-system#2085, whereas the height of their (the buttons') container is dictated by code from older commit. Given the issue carbon-design-system#2085 refers to (carbon-design-system#1956) seems to request simply for the button's height and doesn't seem to mention how buttons' height should work with their container's height, this change moves the code to define the height back to the container. Fixes carbon-design-system#3751.
|
Deploy preview for the-carbon-components ready! Built with commit 3f34c7b https://deploy-preview-3758--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 3f34c7b |
|
Deploy preview for carbon-components-react ready! Built with commit 3f34c7b https://deploy-preview-3758--carbon-components-react.netlify.com |
aledavila
approved these changes
Aug 19, 2019
aledavila
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest code that dictates the height of content switcher buttons is introduced in #2085, whereas the height of their (the buttons') container is dictated by code from older commit. Given the issue #2085 refers to (#1956) seems to request simply for the button's height and doesn't seem to mention how buttons' height should work with their container's height, this change moves the code to define the height back to the container.
@aledavila Please don't hesitate to speak up if I'm missing anything!
Fixes #3751.
Changelog
Changed
40px) in their container, instead of in the buttons themselves.Testing / Reviewing
Testing should make sure content switcher is not broken.