Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(link): use hover color token for visited links #5559

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Mar 6, 2020

Closes #5549

This PR sets the link hover color tokens to $hover-primary-text

Testing / Reviewing

Verify that the link component matches the spec

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✅

@netlify
Copy link

netlify bot commented Mar 6, 2020

Deploy preview for carbon-components-react ready!

Built with commit 94b2eb9

https://deploy-preview-5559--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Mar 6, 2020

Deploy preview for carbon-elements ready!

Built with commit 94b2eb9

https://deploy-preview-5559--carbon-elements.netlify.com

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

@asudoh asudoh merged commit 06b5db9 into carbon-design-system:master Mar 6, 2020
@emyarod emyarod deleted the 5549-link-hover-color-token branch March 9, 2020 18:31
joshblack pushed a commit to joshblack/carbon that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy between React link hover color and spec
7 participants