fix(button): prevent hover on disabled buttons in g90/g100 theme #5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 04bc323 |
|
Deploy preview for carbon-components-react ready! Built with commit 04bc323 https://deploy-preview-5678--carbon-components-react.netlify.com |
joshblack
approved these changes
Mar 23, 2020
emyarod
approved these changes
Mar 23, 2020
abbeyhrt
approved these changes
Mar 23, 2020
tw15egan
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hover state on disabled buttons for dark themes (g90 and g100).
Changelog
Changed
color: $disabled-03for disabled buttons regardless of hover or focus state.Removed
text-decoration: nonefrom hovered/focused disabled buttons as I couldn't see a text decoration showing up when removed. If this is part of a browser compatibility issue, please let me know and I'll add it back.Testing / Reviewing
Additional resources
Current behaviour (can be verified on https://carbon-components-react.netlify.com/?path=/story/buttons--default):
