feat(tokens): add decorative-01, update dropdown styles #5688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
joshblack
approved these changes
Mar 24, 2020
|
Deploy preview for carbon-elements ready! Built with commit 795ff41 |
|
Deploy preview for carbon-components-react ready! Built with commit 795ff41 https://deploy-preview-5688--carbon-components-react.netlify.com |
aledavila
approved these changes
Mar 24, 2020
emyarod
approved these changes
Mar 25, 2020
laurenmrice
reviewed
Mar 25, 2020
There was a problem hiding this comment.
Vanilla looks correct, new token is correct in elements. I don't think it has been changed in react yet though.
Other components that need this token applied for light prop (can either do this in this pr or separate if you want):
- Combobox
- Multi-select
- Overflow menu
|
@laurenmrice do you have specs for what everything should be? Multiselect seems to have some issues with hover colors, want to make sure they are correct. Might be best to create a new issue and I can add them in that way 👍 |
laurenmrice
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2439
Starts the work of fixing visual issues on dark themes when list menus are using
field-02as a background.field-02andui-03are the same value in dark themes, which were causing problems specifically when thelightprop was added toDropdown. When thelightprop was added, the horizontal rules would blend into the background.@laurenmrice this PR is specifically addressing the Dropdown issue. Let me know if there are other components that have a light version that this would also affect.
Changelog
New
decorative-01as a token for horizontal rules on components with alightvariation.Changed
-
lightDropdownmenu now has the correct background offield-02Testing / Reviewing
Run the vanilla components locally, change themes on the Dropdown page, and ensure you can see the horizontal rules on all variations / themes.