-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tokens): add decorative-01, update dropdown styles #5688
Conversation
Deploy preview for carbon-elements ready! Built with commit 795ff41 |
Deploy preview for carbon-components-react ready! Built with commit 795ff41 https://deploy-preview-5688--carbon-components-react.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good after design review @laurenmrice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me pending design review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vanilla looks correct, new token is correct in elements. I don't think it has been changed in react yet though.
Other components that need this token applied for light prop (can either do this in this pr or separate if you want):
- Combobox
- Multi-select
- Overflow menu
@laurenmrice do you have specs for what everything should be? Multiselect seems to have some issues with hover colors, want to make sure they are correct. Might be best to create a new issue and I can add them in that way 👍 |
Closes #2439
Starts the work of fixing visual issues on dark themes when list menus are using
field-02
as a background.field-02
andui-03
are the same value in dark themes, which were causing problems specifically when thelight
prop was added toDropdown
. When thelight
prop was added, the horizontal rules would blend into the background.@laurenmrice this PR is specifically addressing the Dropdown issue. Let me know if there are other components that have a light version that this would also affect.
Changelog
New
decorative-01
as a token for horizontal rules on components with alight
variation.Changed
-
light
Dropdown
menu now has the correct background offield-02
Testing / Reviewing
Run the vanilla components locally, change themes on the Dropdown page, and ensure you can see the horizontal rules on all variations / themes.