Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add use-resize-observer to dependencies #5927

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

joshblack
Copy link
Contributor

Hotfix to add use-resize-observer to dependencies

@joshblack joshblack requested a review from a team as a code owner April 23, 2020 20:59
@ghost ghost requested review from asudoh and emyarod April 23, 2020 20:59
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshblack for catching this!

@netlify
Copy link

netlify bot commented Apr 23, 2020

Deploy preview for carbon-elements ready!

Built with commit acc313b

https://deploy-preview-5927--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 23, 2020

Deploy preview for carbon-components-react ready!

Built with commit acc313b

https://deploy-preview-5927--carbon-components-react.netlify.app

@joshblack joshblack merged commit cb597d7 into master Apr 23, 2020
@joshblack joshblack deleted the joshblack-patch-1 branch April 23, 2020 21:15
joshblack added a commit to joshblack/carbon that referenced this pull request Apr 23, 2020
joshblack added a commit to joshblack/carbon that referenced this pull request Apr 23, 2020
@nictownsend
Copy link
Contributor

Hi Josh, do you guys use Cypress at all? Since updating to CCR 7.11.3 (and CC 10.11.2) all my Cypress tests break in the Cypress runner due to a ResizerObserver loop count exceeded.

SO suggests it's benign - https://stackoverflow.com/questions/49384120/resizeobserver-loop-limit-exceeded - so I'm catching the error in Cypress to allow my tests to run - but just wanted to check if any of you were aware of it?

@asudoh
Copy link
Contributor

asudoh commented May 11, 2020

Hi @nictownsend the error with ResizeObserver you pointed out typically happens if ResizeObserver's callback itself causes resize. Such symptom is not observed with our manual tests in Storybook. That said, wondering if you have any application-level CSS that makes our CodeSnippet code or any application code using ResizeObserver, if any, causes resize.

Anyhow it's good as long as it's in test-environment only and you can work it around in your test (it seems the case). Some other workarounds are overriding the CSS to avoid the resize, or mocking ResizeObserver itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants