-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): add use-resize-observer to dependencies #5927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joshblack for catching this!
Deploy preview for carbon-elements ready! Built with commit acc313b |
Deploy preview for carbon-components-react ready! Built with commit acc313b https://deploy-preview-5927--carbon-components-react.netlify.app |
Hi Josh, do you guys use Cypress at all? Since updating to CCR 7.11.3 (and CC 10.11.2) all my Cypress tests break in the Cypress runner due to a SO suggests it's benign - https://stackoverflow.com/questions/49384120/resizeobserver-loop-limit-exceeded - so I'm catching the error in Cypress to allow my tests to run - but just wanted to check if any of you were aware of it? |
Hi @nictownsend the error with Anyhow it's good as long as it's in test-environment only and you can work it around in your test (it seems the case). Some other workarounds are overriding the CSS to avoid the resize, or mocking |
Hotfix to add
use-resize-observer
to dependencies