docs(DataTable): add playground story #6842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 1010647 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 1010647 https://deploy-preview-6842--carbon-components-react.netlify.app |
joshblack
suggested changes
Sep 15, 2020
There was a problem hiding this comment.
Ah, totally blanked on the knobs. Thanks for adding in the playground example. Left a couple of comments, namely that for most stories we want people to be able to copy and paste them without any problems. The playground story is different though and doesn't need to follow this example since it uses knobs 👍
emyarod
force-pushed
the
data-table-docs-playground
branch
from
56f098e
to
85d2ab2
Compare
tw15egan
reviewed
Sep 16, 2020
36 tasks
emyarod
force-pushed
the
data-table-docs-playground
branch
from
85d2ab2
to
b19e83c
Compare
tw15egan
approved these changes
Sep 17, 2020
joshblack
approved these changes
Sep 17, 2020
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a playground story to the DataTable docs so that props like
useZebraStyles,size, andstickyHeadercan be tested and applied. This is useful for devs and designers when confirming positioning and alignment issues in tablesChangelog
New
Changed
Testing / Reviewing
Ensure the storybook knobs for the default data table stories are correct as well as the playground story