-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): Increase Windows / Firefox HCM support #6892
fix(a11y): Increase Windows / Firefox HCM support #6892
Conversation
Deploy preview for carbon-elements ready! Built with commit e876c58 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit e876c58 https://deploy-preview-6892--carbon-components-react.netlify.app |
@tw15egan would this help out at all as a top-level reset? https://github.com/carbon-design-system/carbon/blob/master/packages/icons/scss/mixins.scss Not sure if it overlaps or not, just saw that this involved icons and remember that we used that for HCM at some point 🤔 Maybe if we update it to include the |
bump @dakahn when you have a sec to review 👀 |
@joshblack I noticed that, and it looks like we already pull it in via our reset:
Problem is, anywhere we define a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome freakin job! 💪
@tw15egan ah that makes a ton of sense, thanks for explaining. |
@joshblack @dakahn do we want to go forward as-is? Or do we want to change it so that mixin takes precedence in HCM with an |
@tw15egan I think going forward as-is works out, maybe we could add a lint rule to stylelint to warn us about this in the future? |
Closes #6859 [Slider]
Closes #6767 [Pagination]
Closes #6471 [Checkbox]
Closes #6862 [Modal]
Closes #6748 [Radio Button]
Closes #6755 [Select]
Adds in Windows and Firefox HCM support. This PR focuses on ensuring all elements are
visible
, especially icons. Focus issues will be addressed in a separate PR (mainly for the Firefox HCM support, Edge is pretty good).Changelog
New
HCM changes to the following components
Changed
stylelint
package to not throw an error with the unreleasedprefers-contrast
flagTesting / Reviewing
On a Windows 10 machine, go to
settings --> ease of access --> high contrast
and flick the switch. Compare the storybook in Edge (Should be in High Contrast) to Chrome (Should look normal).For Firefox, you'll need to open it up and type
about:config
into the address bar. Then, search forlayout.css.prefers-contrast
and set it totrue
.Ensure there are no missing UI elements for the following components: