fix(content-switcher): provide empty default onChange prop #6945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit b2e1c37 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit b2e1c37 https://deploy-preview-6945--carbon-components-react.netlify.app |
dakahn
approved these changes
Oct 3, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the ContentSwitcher from throwing an error when no
onChangeprop is passed yet. Demo of current behaviour (click on "two" or "three"): https://l4ijp.csb.app/Changelog
New
() => {}as default onChange propChanged
Testing / Reviewing
onChangeprop from the ContentSwitcher playground story and verify that it does not throw an error as it does in the codesandbox