fix(Tabs): select tab do not vertical scroll into view #6974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change experimental argument to non experimental argument type
|
Deploy preview for carbon-elements ready! Built with commit b2afa43 |
|
Deploy preview for carbon-elements ready! Built with commit d1ed5c8 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit b2afa43 https://deploy-preview-6974--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit d1ed5c8 https://deploy-preview-6974--carbon-components-react.netlify.app |
emyarod
approved these changes
Oct 7, 2020
tw15egan
approved these changes
Oct 7, 2020
tw15egan
pushed a commit
to tw15egan/carbon
that referenced
this pull request
Oct 7, 2020
…-system#6974) * fix(Tabs): select tab do not vertical scroll into view * fix(Tabs): change argument type for scrollIntoView api change experimental argument to non experimental argument type Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This was referenced Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6973
Prevent vertical scrolling when selecting tabs
Changelog
No longer vertically scrolls on new tab selection.
Use regular (bool) argument for the scrollIntoView api instead of the experimental (object) type argument, ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView
Testing / Reviewing