-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(accordion): add disabled state to accordion #7005
feat(accordion): add disabled state to accordion #7005
Conversation
36edef6
to
c3d8ace
Compare
Deploy preview for carbon-elements ready! Built with commit 36edef6 |
Deploy preview for carbon-components-react ready! Built with commit 36edef6 https://deploy-preview-7005--carbon-components-react.netlify.app |
Deploy preview for carbon-elements ready! Built with commit f25afa8 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit f25afa8 https://deploy-preview-7005--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For prop naming, what would be the best convention for went to decide between disabled
and isDisabled
?
One quick rule of thumb was that isDisabled
is used for custom components and disabled
is relegated to HTML elements but not sure how effective that is? 🤷
@joshblack essentially the I did wonder about other props like |
@tw15egan I'm down with that, makes a lot of sense to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍🏻
I think that the Gray 10 theme may need a value change for the disabled-01 token, but I can look into that and open a separate issue.
bump @aledavila when you get a sec today 👀 |
Closes #7000
Adds in
disabled
state forAccordion
andAccordionItem
Changelog
New
disabled
prop forAccordion
andAccordionItem
Changed
Accordion
, and the other to disable just one item.Testing / Reviewing
Go to
Accordion Playground
and try disabling the entire Accordion as well as an AccordionItem