Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): Fixing Overflow menu accessibility on Window High Contrast Mode #7104

Merged

Conversation

rjhenriquez
Copy link
Contributor

Closes #6889

Fixing Overflow menu accessibility on Window High Contrast Mode

Changelog

Changed

Overflow Menu component

Testing / Reviewing

On a Windows 10 machine, go to settings --> ease of access --> high contrast and flick the switch. Compare the storybook in Edge (Should be in High Contrast) to Chrome (Should look normal).
For Firefox, you'll need to open it up and type about:config into the address bar. Then, search for layout.css.prefers-contrast and set it to true.

  • Visit Overflow Menu component
  • Verify that the icon shows properly
  • Verify the focus state works on the icon
  • Verify that focus state works on the menu options

@rjhenriquez rjhenriquez requested a review from a team as a code owner October 21, 2020 15:06
@netlify
Copy link

netlify bot commented Oct 21, 2020

Deploy preview for carbon-elements ready!

Built with commit c4ae5d0

https://deploy-preview-7104--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 21, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit c4ae5d0

https://deploy-preview-7104--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 3ebe006 into carbon-design-system:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow menu is not accessible in Windows High Contrast mode on Firefox
3 participants