fix(NumberInput): restore defaultValue prop functionality in uncontrolled number input
#7312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
force-pushed
the
7299-uncontrollednumberinput-defaultvalue
branch
from
315c2bb
to
6797fff
Compare
|
Deploy preview for carbon-elements ready! Built with commit 315c2bb |
|
Deploy preview for carbon-components-react ready! Built with commit 315c2bb https://deploy-preview-7312--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 16ae7c4 |
joshblack
approved these changes
Nov 18, 2020
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 16ae7c4 https://deploy-preview-7312--carbon-components-react.netlify.app |
andreancardona
approved these changes
Nov 18, 2020
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7299
This PR restores functionality to the
defaultValueprop in uncontrolled number inputs and removes the React warning about setting bothdefaultValueandvalueon the inputChangelog
New
defaultValuetestChanged
defaultValueinto inputdefaultValuetypecheckgDSFPTesting / Reviewing
Confirm that setting a
defaultValueon an uncontrolled number input works as expected and the correct value is displayed on render