-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(colors): add support for Sass Modules #7395
feat(colors): add support for Sass Modules #7395
Conversation
鉁旓笍 Deploy preview for carbon-elements ready! 馃敤 Explore the source changes: 94b373f 馃攳 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd39f141c1177000870dc67 馃槑 Browse the preview: https://deploy-preview-7395--carbon-elements.netlify.app |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 94b373f https://deploy-preview-7395--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great! Thanks for running through it with me 馃憤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Thanks for the explanation!
Adds support for Sass Modules with the colors package through
@carbon/colors/scss/module.scss
The generated code for this module looks like:
This PR also adds in an example for bringing in
@carbon/colors
to a project and using it as a Sass Module 馃憖Changelog
New
module.scss
to@carbon/colors
Changed
Removed
Testing / Reviewing
yarn build
in@carbon/colors
module.scss
file is built inpackages/colors/scss/module.scss
colors/examples/sass-modules
and then runyarn install
andyarn develop
and verify the color variables work as intended