Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): deprecate disabled-background-color #7426

Conversation

epodgaetskiy
Copy link
Contributor

@epodgaetskiy epodgaetskiy commented Dec 9, 2020

This PR makes compliance with [the guide](This PR makes compliance with the guide of date-picker, the guide of number-input, the guide of search, the guide of select

Changelog

Changed

  • replacement the background-color from disabled-background-color to disabled-01 for date-picker, number-input, search, select the guide

Testing / Reviewing

  • Pull PR
  • Look fix at netlify storybook for date-picker, number-input, search, select

@epodgaetskiy epodgaetskiy requested a review from a team as a code owner December 9, 2020 16:19
@epodgaetskiy epodgaetskiy changed the title fix(components): depracate disabled background color fix(components): deprecate disabled-background-color Dec 9, 2020
@netlify
Copy link

netlify bot commented Dec 9, 2020

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 2b081d2

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd14f4aa74a9d000707bcc0

😎 Browse the preview: https://deploy-preview-7426--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 9, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 2b081d2

https://deploy-preview-7426--carbon-components-react.netlify.app

@laurenmrice laurenmrice requested review from laurenmrice and removed request for johnbister December 9, 2020 17:47
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! Thank you 🙌🏻

@kodiakhq kodiakhq bot merged commit fba0cbd into carbon-design-system:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants